Skip to content

chore: update Go module dependencies to latest versions - #78

Closed
fsul7o wants to merge 4 commits into
masterfrom
update-package-20260917
Closed

fsul7o wants to merge 4 commits into
masterfrom
update-package-20260917

Conversation

@fsul7o

@fsul7o fsul7o commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

Description

update Go module dependencies to latest versions

and

Fix TestDescribe failure caused by prometheus/client_golang upgrade

TestDescribe in service/metrics_test.go started failing after prometheus/client_golang was bumped to v1.24.1 in the recent dependency update. That version added a unit field to prometheus.Desc, so Desc.String() now renders as:

Desc{fqName: "...", help: "...", unit: "", constLabels: {}, variableLabels: {}}

The test's expected strings for cached_principal_bytes and cached_principal_entries were written against the old format (without unit: "") and no longer matched.

This is a test-only change — no production behavior is affected. NewDesc() is called without any DescOpt, so unit stays an empty string internally and is never appended to the metric name; the actual /metrics exposition output for cached_principal_bytes / cached_principal_entries is unchanged.

Type of change

  • Bug fix
  • New feature
  • Refactoring (no functional changes, no api changes)
  • Non-code changes (update documentation, pipeline, etc.)

Flags

  • Breaks backward compatibility
  • Requires a documentation update
  • Has untestable code

Related issue/PR

Delete this section if there are no issues or pull requests that relate to this pull request.

  • Fixes #issue
  • Closes #PR

Checklist

  • Followed the guidelines in the CONTRIBUTING document
  • Added prefix [skip ci]/[ci skip]/[no ci]/[skip actions]/[actions skip] in the PR title if necessary
  • Tested and linted the code
  • Commented the code
  • Made corresponding changes to the documentation
  • Passed all pipeline checking

Checklist for maintainer

  • Use Squash and merge
  • Double-confirm the merge message has prefix [skip ci]/[ci skip]/[no ci]/[skip actions]/[actions skip]
  • Delete the branch after merge

Signed-off-by: fsul7o <75571344+fsul7o@users.noreply.github.com>
Signed-off-by: fsul7o <75571344+fsul7o@users.noreply.github.com>
Comment thread go.mod
replace (
cloud.google.com/go => cloud.google.com/go v0.123.0
github.com/AthenZ/athenz-authorizer/v5 => github.com/AthenZ/athenz-authorizer/v5 v5.8.4
github.com/AthenZ/athenz-authorizer/v5 => github.com/AthenZ/athenz-authorizer/v5 v5.8.5-0.20260917024127-31c36c01e6a8

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

Suggested change
github.com/AthenZ/athenz-authorizer/v5 => github.com/AthenZ/athenz-authorizer/v5 v5.8.5-0.20260917024127-31c36c01e6a8
github.com/AthenZ/athenz-authorizer/v5 => github.com/AthenZ/athenz-authorizer/v5 v5.8.5

Comment thread go.mod Outdated
Signed-off-by: fsul7o <75571344+fsul7o@users.noreply.github.com>
@mlajkim mlajkim added the dependencies Pull requests that update a dependency file label Sep 29, 2026
@fsul7o fsul7o closed this Sep 30, 2026
@fsul7o
fsul7o deleted the update-package-20260917 branch September 30, 2026 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants