Conversation
Signed-off-by: fsul7o <75571344+fsul7o@users.noreply.github.com>
Signed-off-by: fsul7o <75571344+fsul7o@users.noreply.github.com>
t4niwa
reviewed
Sep 17, 2026
| replace ( | ||
| cloud.google.com/go => cloud.google.com/go v0.123.0 | ||
| github.com/AthenZ/athenz-authorizer/v5 => github.com/AthenZ/athenz-authorizer/v5 v5.8.4 | ||
| github.com/AthenZ/athenz-authorizer/v5 => github.com/AthenZ/athenz-authorizer/v5 v5.8.5-0.20260917024127-31c36c01e6a8 |
Contributor
There was a problem hiding this comment.
TODO
Suggested change
| github.com/AthenZ/athenz-authorizer/v5 => github.com/AthenZ/athenz-authorizer/v5 v5.8.5-0.20260917024127-31c36c01e6a8 | |
| github.com/AthenZ/athenz-authorizer/v5 => github.com/AthenZ/athenz-authorizer/v5 v5.8.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
update Go module dependencies to latest versions
and
Fix TestDescribe failure caused by prometheus/client_golang upgrade
TestDescribe in service/metrics_test.go started failing after prometheus/client_golang was bumped to v1.24.1 in the recent dependency update. That version added a unit field to prometheus.Desc, so Desc.String() now renders as:
The test's expected strings for cached_principal_bytes and cached_principal_entries were written against the old format (without unit: "") and no longer matched.
This is a test-only change — no production behavior is affected. NewDesc() is called without any DescOpt, so unit stays an empty string internally and is never appended to the metric name; the actual /metrics exposition output for cached_principal_bytes / cached_principal_entries is unchanged.
Type of change
Flags
Related issue/PR
Delete this section if there are no issues or pull requests that relate to this pull request.
Checklist
[skip ci]/[ci skip]/[no ci]/[skip actions]/[actions skip]in the PR title if necessaryChecklist for maintainer
Squash and merge[skip ci]/[ci skip]/[no ci]/[skip actions]/[actions skip]