Merge development into production - #473
Merged
Merged
Conversation
The expedition-logo-paths operation has run in production. Remove it and its tests, and set update_queries_operation back to '' so deploys skip app:update-queries.
Remove completed expedition logo update operation
Each load-more request re-rendered every previously loaded card and rehydrated all of their models, so requests grew with the list. - Wrap the card list in all six index components in a `cards` island. The load-more sentinel lives inside it with wire:island.append, so a scroll renders and appends only the next page. The island renders with the component (always: true) so sorting and type changes reset it. - Keep only the current page in component state instead of concatenating every loaded page; remove hydrateRecords() and the ProjectService methods that existed only for it. - ProjectPresenter::showLogo() builds the URL without an S3 exists() call. - Project and expedition logo images fall back to the default image in the browser when the file is missing. Closes #452
Render only new cards on incremental index load-more Fixes #452
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Included
exists()call per card.update_queries_operationis'', so the deploy skipsapp:update-queries)Deployment
artisan:queue:restartand clears caches as usual.Validation