Repository navigation
Only deliver locally to inbox routes - #3968
Merged
Merged
Conversation
1 of 11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed changes:
Dispatcher::send_to_local_inbox()now only dispatches the shared inbox and the actor inboxes (/inbox,/actors/<id>/inbox,/users/<id>/inbox). Any other route returns anactivitypub_invalid_inboxerror, which is not retried.Other information:
Real local deliveries already go to these routes, and inboxes on other hosts are still delivered over HTTP, so nothing changes for them.
Testing instructions:
vendor/bin/phpunit --filter test_local_delivery_only_reaches_inbox_routesChangelog entry
Changelog Entry Details
Significance
Type
Message