Skip to content

Leave moderation alone when searching for a reply - #3970

Merged
pfefferle merged 3 commits into
trunkfrom
fix/search-import-moderation
Oct 27, 2026
Merged

pfefferle merged 3 commits into
trunkfrom
fix/search-import-moderation

Conversation

@pfefferle

Copy link
Copy Markdown
Member

Fixes #

Proposed changes:

  • Searching for the URL of a reply (front-end search and the admin comment search) imports the reply if needed and redirects to it. It also approved the comment, for new imports and for comments that already existed, whatever their status was.
  • The search no longer approves anything. A newly imported reply follows the comment moderation settings, like a reply that arrives through the inbox, and an existing comment keeps its status. The import and the redirect stay as they were.

Other information:

  • Have you written new tests for your changes, if applicable?

The activitypub capability includes authors, who cannot moderate comments otherwise, and the search runs on a plain GET request.

Testing instructions:

  • vendor/bin/phpunit --filter test_search_keeps_comment_status
  • Hold a remote reply for moderation, search for its URL in the admin comment search, and check that it is still pending afterwards.

Changelog entry

  • Automatically create a changelog entry from the details below.
Changelog Entry Details

Significance

  • Patch
  • Minor
  • Major

Type

  • Added - for new features
  • Changed - for changes in existing functionality
  • Deprecated - for soon-to-be removed features
  • Removed - for now removed features
  • Fixed - for any bug fixes
  • Security - in case of vulnerabilities

Message

@pfefferle pfefferle self-assigned this Oct 27, 2026
@pfefferle
pfefferle requested a review from a team October 27, 2026 16:40
@pfefferle
pfefferle merged commit 243ecff into trunk Oct 27, 2026
11 checks passed
@pfefferle
pfefferle deleted the fix/search-import-moderation branch October 27, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant