[pfefferle]

Fixes #

Proposed changes:

• The featured collection queried sticky posts and only left out posts with a content visibility set. A password-protected sticky post, or one whose post type no longer supports ActivityPub, was still listed and counted (its content was already redacted to a Tombstone).
• The query result now goes through is_post_publicly_queryable(), the same check the router and the other controllers use. The meta_query stays as a cheap pre-filter.
• totalItems uses count() directly, since $posts is always a list now.

Other information:

• Have you written new tests for your changes, if applicable?

Testing instructions:

• vendor/bin/phpunit --filter test_get_featured_skips_password_protected_posts
• Make two posts sticky, protect one with a password, and check that /wp-json/activitypub/1.0/actors/<id>/collections/featured only lists the other one.

Changelog entry

• Automatically create a changelog entry from the details below.

Changelog Entry Details

Significance

• Patch
• Minor
• Major

Type

• Added - for new features
• Changed - for changes in existing functionality
• Deprecated - for soon-to-be removed features
• Removed - for now removed features
• Fixed - for any bug fixes
• Security - in case of vulnerabilities

Message