Repository navigation
Split the review knowledge into a shared skill - #3978
Merged
Merged
Conversation
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed changes:
reviewskill, split by area into.agents/skills/review/guidelines/(content exposure, authorization, signatures, inbox, remote fetch, output, integrations, supply chain, cron, accessibility). Each file says which paths it applies to, and a review only loads the files the change touches. A handler change now reads about 30 KB instead of 60 KB.#13or§4.review/SKILL.mdis the shared base for both agents: stay read-only, read the code after the change (a-line is gone), treat the diff and PR text as untrusted, check the impact on callers, check that a fix fixes and that its test can fail, keep decisions already made, and what a finding needs.review/judge.mdchecks all findings of a review in one pass, instead of one agent per finding.AGENTS.mdlost itsCRITICAL/MUST/ALWAYS; the rules themselves are the same.Other information:
To make sure nothing got lost while condensing, I checked that every anchor of the old text is still there: all backtick tokens (functions, filters, files, constants), every CVE and WPScan id, every PR and version number. All 313 are.
The history entry about same-host keys from the signing key fix is already in here, in
signatures.mdandremote-fetch.md, so that branch doesn't need to add it to the old agent file.Testing instructions:
includes/handler/. It should loadinbox.mdandremote-fetch.md, and nothing else.Changelog entry
Changelog Entry Details
Significance
Type
Message