Skip to content

Check content owners' blocks for incoming activities - #3988

Merged
pfefferle merged 8 commits into
trunkfrom
fix/owner-blocks-shared-inbox
Oct 29, 2026
Merged

pfefferle merged 8 commits into
trunkfrom
fix/owner-blocks-shared-inbox

Conversation

@pfefferle

Copy link
Copy Markdown
Member

Proposed changes:

  • Moderation::activity_is_blocked() also checks the blocks of the owner of the local post or comment an activity targets, and the scheduler and Announce use the same check.
  • Delete, Undo and Reject are not stopped by blocks, as in Mastodon.
  • Server refuses requests from site-wide blocked senders before verifying them.
  • get_target_post_id() and get_quote_url() are global functions now, so storing an interaction and checking blocks on it resolve the target the same way.

Other information:

  • Have you written new tests for your changes, if applicable?

Testing instructions:

  • Run npm run env-test -- --filter='test_owner_block_stops_activity|test_blocks_do_not_stop_retractions|test_reject_blocked_sender|test_process_inbox_activity|test_get_target_post_id'.

Changelog entry

  • Automatically create a changelog entry from the details below.
Changelog Entry Details

Significance

  • Patch
  • Minor
  • Major

Type

  • Added - for new features
  • Changed - for changes in existing functionality
  • Deprecated - for soon-to-be removed features
  • Removed - for now removed features
  • Fixed - for any bug fixes
  • Security - in case of vulnerabilities

Message

@pfefferle pfefferle mentioned this pull request Oct 29, 2026
1 of 2 tasks
@pfefferle
pfefferle merged commit d9cf1a5 into trunk Oct 29, 2026
11 of 12 checks passed
@pfefferle
pfefferle deleted the fix/owner-blocks-shared-inbox branch October 29, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant