Repository navigation
Check content owners' blocks for incoming activities - #3988
Merged
Merged
Conversation
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Moderation::activity_is_blocked()also checks the blocks of the owner of the local post or comment an activity targets, and the scheduler and Announce use the same check.Serverrefuses requests from site-wide blocked senders before verifying them.get_target_post_id()andget_quote_url()are global functions now, so storing an interaction and checking blocks on it resolve the target the same way.Other information:
Testing instructions:
npm run env-test -- --filter='test_owner_block_stops_activity|test_blocks_do_not_stop_retractions|test_reject_blocked_sender|test_process_inbox_activity|test_get_target_post_id'.Changelog entry
Changelog Entry Details
Significance
Type
Message