feat: edit standalone images through source projection - #492
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related Issue
Closes #313
Verification
pnpm exec vitest run src/features/editor/tests/sourceProjectionImage.test.ts src/features/editor/tests/sourceProjectionImageLink.test.ts src/features/editor/plugins/imageView.test.ts— verifies retained standalone and linked images, pointer and keyboard entry, boundary exit, valid and literal commits, history, clipboard behavior, and unavailable states.pnpm check:frontend— verifies formatting, TypeScript and Oxlint checks, the production frontend build, and the complete frontend test suite with coverage thresholds.Not verified: Windows desktop E2E and manual application interaction were not run locally.
Notes
The projection deliberately adds one 28-pixel source line before the retained image while editing. This keeps source as native document text with ordinary ProseMirror selection behavior; avoiding that temporary layout shift would require returning to an overlay or detached control model.
Structured image controls, including file replacement, were deferred to the
Design structured image editing controlsProject draft rather than coupled to source projection. Links with mixed text, multiple images, or other label content keep the existing source-only whole-link projection.