Skip to content

feat: edit standalone images through source projection - #492

Merged
Azganoth merged 2 commits into
mainfrom
feature/standalone-image-projection
Sep 21, 2026
Merged

Azganoth merged 2 commits into
mainfrom
feature/standalone-image-projection

Conversation

@Azganoth

Copy link
Copy Markdown
Owner

Summary

  • Replace the detached image Markdown input and duplicate parsing path with the shared in-document source projection engine, including parser-backed edits, projection-local history and clipboard behavior, and authored-target preservation when rendered images move.
  • Keep standalone images and links whose complete label is one image mounted beneath a 28-pixel source line, with pointer entry at the alt text, directional keyboard entry, clean boundary exit, and short path-free unavailable states.
  • Update the product specification, architecture record, changelog, focused editor coverage, and desktop E2E expectations for the final interaction model.

Related Issue

Closes #313

Verification

  • pnpm exec vitest run src/features/editor/tests/sourceProjectionImage.test.ts src/features/editor/tests/sourceProjectionImageLink.test.ts src/features/editor/plugins/imageView.test.ts — verifies retained standalone and linked images, pointer and keyboard entry, boundary exit, valid and literal commits, history, clipboard behavior, and unavailable states.
  • pnpm check:frontend — verifies formatting, TypeScript and Oxlint checks, the production frontend build, and the complete frontend test suite with coverage thresholds.

Not verified: Windows desktop E2E and manual application interaction were not run locally.

Notes

The projection deliberately adds one 28-pixel source line before the retained image while editing. This keeps source as native document text with ordinary ProseMirror selection behavior; avoiding that temporary layout shift would require returning to an overlay or detached control model.

Structured image controls, including file replacement, were deferred to the Design structured image editing controls Project draft rather than coupled to source projection. Links with mixed text, multiple images, or other label content keep the existing source-only whole-link projection.

@github-project-automation github-project-automation Bot moved this to Backlog in Leafdown Sep 21, 2026
@Azganoth Azganoth added the Feature New feature or request label Sep 21, 2026
@Azganoth Azganoth self-assigned this Sep 21, 2026
@Azganoth
Azganoth merged commit fccada9 into main Sep 21, 2026
3 checks passed
@Azganoth
Azganoth deleted the feature/standalone-image-projection branch September 21, 2026 16:24
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Leafdown Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Rework standalone image editing around source projection

1 participant