feat: add hierarchical block selection - #497
Merged
Merged
Conversation
This was referenced Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related Issue
Closes #478
Verification
pnpm exec vitest run src/features/editor/plugins/blockSelection.test.ts src/features/editor/plugins/blockSelectionInteraction.test.ts src/features/editor/plugins/blockSelectionProjection.test.ts src/features/editor/plugins/contextPopup.test.ts src/features/editor/commands/formatting/blocks.test.ts src/features/editor/tests/editorPresentation.test.tsverifies exact cross-list ranges, replacement, mapping, source projection, pointer interaction, popup integration, formatting, and presentation.pnpm check:frontendverifies formatting, TypeScript, Oxlint, the production build, and the complete frontend coverage suite.pnpm build:e2e:desktopbuilds the assembled desktop test binary.pnpm test:e2e:desktop:run -- --scenario block-selectionverifies nested gutter geometry, handle visibility and expansion, selection stability, popup behavior, focus, and exact cross-list presentation in the Windows WebView.Not verified: the full desktop E2E suite or a separate manual interactive Tauri pass.
Notes
Cross-parent ranges use exact selectable-block endpoints and ProseMirror open structural slices instead of promoting endpoints to list wrappers. This intentionally supersedes the original lowest-common-ancestor promotion detail in #478 because promotion visually and operationally absorbed adjacent list items; the final behavior is recorded in the specification and decision record.