Conversation
Collaborator
Author
|
Closing in favour of #25520, which carries this same change ( Created by claudebox · group: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
RollupConfiguration.useRealVerifier()readsREAL_VERIFIERwith a default offalse.DeployRollupLib._deployVerifierdeploysMockVerifieronfalse, andMockVerifier.verifyreturnstruefor any proof and public inputs. The verifier is fixed atRollupconstruction with no setter, so runningDeployAztecL1ContractsorDeployRollupForUpgradedirectly through Forge without settingREAL_VERIFIER=trueproduces a rollup whosesubmitEpochRootProofaccepts arbitrary proof bytes for its whole lifetime. The mock is the correct choice only for local and test networks, so it has to be an explicit opt-out, not the fail-open default.Refs AztecProtocol/aztec-claude#840.
Change
RollupConfiguration.useRealVerifier()defaults totrue.REAL_VERIFIER=falsestill selectsMockVerifierfor local and test deployments.scripts/run_rollup_upgrade.shno longer sets its ownREAL_VERIFIERdefault, which duplicated the Solidity default.test_DeploysRealVerifierByDefaultruns the full deploy script withREAL_VERIFIERunset and asserts the rollup'sgetEpochProofVerifier()has theHonkVerifiercodehash.No on-chain contract changes.
RollupCore,EpochProofLibandMockVerifierare untouched, so there is no gas impact on any deployed contract.What this does not change
aztec-node's deployer (deploy_aztec_l1_contracts.ts) always setsREAL_VERIFIERexplicitly to'true'or'false'from itsrealVerifierargument, so node-driven deployments and e2e tests behave exactly as before. The--real-verifierCLI flag in that repo still defaults tofalse; flipping that is a separate change inaztec-labs-eng/aztec-node, which is why this PR usesRefsrather thanCloses.HonkVerifier.solchecked intov5-nextforDeployRollupForUpgradeV5.s.sol, and the previous (v4 line) rollup's verifier code hash matches the constant pinned inDeployAlpha.s.sol. Neither mainnet script consults this default; the generic script's default only reaches a deployment when someone runs it by hand.Tests
Red, on
nextbefore the fix:Green after the fix, and the rest of the suite:
Created by claudebox · group:
slackbot· requested by Mike (@iAmMichaelConnor) · Slack thread