Skip to content

docs(l1): state that the generic deploy scripts are the test/testnet deployer, not the mainnet path - #25519

Merged
iAmMichaelConnor merged 3 commits into
nextfrom
cb/l1-deploy-scripts-doc
Sep 21, 2026
Merged

iAmMichaelConnor merged 3 commits into
nextfrom
cb/l1-deploy-scripts-doc

Conversation

@AztecBot

Copy link
Copy Markdown
Collaborator

Summary

Comment-only change. l1-contracts/script/deploy/ (DeployAztecL1Contracts.s.sol, DeployRollupForUpgrade.s.sol, DeployRollupLib.sol, RollupConfiguration.sol) is the env-driven deployer for tests, spartan/CLI and testnets. Nothing in the tree says so, and a reader who finds REAL_VERIFIER defaulting to a mock verifier or genesis roots defaulting to zero can reasonably conclude that mainnet is one unset variable away from a bad deployment.

It is not. Mainnet's one-off contracts were deployed from AztecProtocol/ignition-contracts, and each mainnet rollup version is deployed by a bespoke pinned script, DeployRollupForUpgradeV<N>.s.sol, that hard-codes and re-verifies that deployment's configuration: v5 from DeployRollupForUpgradeV5.s.sol on the v5-next branch, v6 from DeployRollupForUpgradeV6.s.sol (#25496).

Change

  • A doc comment on each of the four generic script files stating what they are for, that mainnet uses the pinned per-version scripts, and that the env defaults are test-network conveniences.
  • One sentence on the root CLAUDE.md line that introduces l1-contracts/, so agents working in the tree do not classify generic-script defaults as mainnet findings.

No bytecode, behaviour, gas or test changes. forge fmt --check passes on the four files.


Created by claudebox · group: slackbot · requested by Mike (@iAmMichaelConnor) · Slack thread

@AztecBot AztecBot added ci-draft Run CI on draft PRs. ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure claudebox Owned by claudebox. it can push to this PR. labels Sep 21, 2026
@iAmMichaelConnor
iAmMichaelConnor marked this pull request as ready for review September 21, 2026 22:29
@iAmMichaelConnor
iAmMichaelConnor enabled auto-merge (squash) September 21, 2026 22:29
@AztecBot

Copy link
Copy Markdown
Collaborator Author

Flakey Tests

🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (8;;http://ci.aztec-labs.com/6a27ff87182d0f97�6a27ff87182d0f978;;�): cd labs && export root= ci3= &&  yarn-project/end-to-end/scripts/run_test.sh simple src/single-node/cross-chain/inbox_bot.test.ts (345s) (code: 0) group:e2e-p2p-epoch-flakes

@iAmMichaelConnor
iAmMichaelConnor merged commit f953bd3 into next Sep 21, 2026
17 of 19 checks passed
@iAmMichaelConnor
iAmMichaelConnor deleted the cb/l1-deploy-scripts-doc branch September 21, 2026 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-draft Run CI on draft PRs. ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants