docs(l1): state that the generic deploy scripts are the test/testnet deployer, not the mainnet path - #25519
Merged
Conversation
…deployer, not the mainnet path
iAmMichaelConnor
approved these changes
Sep 21, 2026
iAmMichaelConnor
marked this pull request as ready for review
September 21, 2026 22:29
iAmMichaelConnor
enabled auto-merge (squash)
September 21, 2026 22:29
Collaborator
Author
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comment-only change.
l1-contracts/script/deploy/(DeployAztecL1Contracts.s.sol,DeployRollupForUpgrade.s.sol,DeployRollupLib.sol,RollupConfiguration.sol) is the env-driven deployer for tests, spartan/CLI and testnets. Nothing in the tree says so, and a reader who findsREAL_VERIFIERdefaulting to a mock verifier or genesis roots defaulting to zero can reasonably conclude that mainnet is one unset variable away from a bad deployment.It is not. Mainnet's one-off contracts were deployed from
AztecProtocol/ignition-contracts, and each mainnet rollup version is deployed by a bespoke pinned script,DeployRollupForUpgradeV<N>.s.sol, that hard-codes and re-verifies that deployment's configuration: v5 fromDeployRollupForUpgradeV5.s.solon thev5-nextbranch, v6 fromDeployRollupForUpgradeV6.s.sol(#25496).Change
CLAUDE.mdline that introducesl1-contracts/, so agents working in the tree do not classify generic-script defaults as mainnet findings.No bytecode, behaviour, gas or test changes.
forge fmt --checkpasses on the four files.Created by claudebox · group:
slackbot· requested by Mike (@iAmMichaelConnor) · Slack thread