Re-generate foundry-cost-control extension from latest TypeSpec in Main branch

[Darren Cohen (dargilco)]

🤖 PR Validation — ️✔️ All clear

Breaking Changes
️✔️ None

---

Link to aaz PR: Azure/aaz#1124

Validated with live tests and test from updated recordings.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

• [DONE] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
• [DONE] Have you run python scripts/ci/test_index.py -q locally? (pip install azdev required)
• [DONE] My extension version conforms to the Extension version schema

For new extensions:

• [DONE] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

[azure-pipelines]

Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

[Aditya Pujara (a0x1ab)]

/azp run

[azure-pipelines]

Azure Pipelines:
Successfully started running 2 pipeline(s).

[Aditya Pujara (a0x1ab)]

/azp run

[azure-pipelines]

Azure Pipelines:
Successfully started running 2 pipeline(s).

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Aditya Pujara (a0x1ab)]

/azp run

[azure-pipelines]

Azure Pipelines:
Successfully started running 2 pipeline(s).

[Aditya Pujara (a0x1ab)]

/azp run

[azure-pipelines]

Azure Pipelines:
Successfully started running 2 pipeline(s).

[x-engineering-agent]

X Engineering Agent Report

Review — Comments

Darren Cohen (@dargilco)

CI completed without failures, but the generated-command source link and focused nested-rule regression assertions are still missing. This review uses upstream CI and author-provided evidence; no Agent live test was requested or run.

Upstream CI

Current-head validation has no failed or pending checks. The description reports live testing and playback with updated recordings; that is author-provided evidence, not independent verification of every migrated field.

Test validation

• Agent live test: Not run; this is a review-only PR. Check author-provided test evidence and upstream CI separately.
• Regression coverage: Not applicable to the changed files.

That shared helper result does not establish scenario coverage for foundry-cost-control. The migration changes counterKey from a list to an object, capitalizes enum values, renames match fields, and requires create-threshold action. The changed recording is src/foundry-cost-control/azext_foundry_cost_control/tests/latest/recordings/test_foundry_cost_control.yaml; successful playback alone does not prove the outgoing fields or their returned values are correct.

Test-strength finding — PR-related. In src/foundry-cost-control/azext_foundry_cost_control/tests/latest/test_foundry_cost_control.py:124-151, the two create cases validate identity/display name and rule name, not the changed nested mappings. The show/update assertions at lines 249-285 likewise check the rule name while the update changes only display name. They can remain green if counterKey.type, match IDs, or threshold values/actions are dropped or mis-mapped, and do not prove the claimed preservation of unspecified rules.

Add request-body and returned-output assertions for Agent and Project fixtures, all renamed match fields, the object-shaped counter key, enum values, and both thresholds. Compare the complete rules before and after the display-name-only update. Include focused omitted-action/default and invalid-input cases to establish the new required-property behavior. Use the two cost-control-rules-*.json fixtures in that test directory; rerun azdev test test_foundry_cost_control for playback and azdev test test_foundry_cost_control --live for service-backed verification, capturing sanitized evidence in the recording path above. These are coverage requirements, not a claim that the service currently rejects the schema.

Repository policy findings

• Generated code ownership checker (blocking) — src/foundry-cost-control/azext_foundry_cost_control/aaz/latest/cognitiveservices/account/costcontrol/_create.py:112, src/foundry-cost-control/azext_foundry_cost_control/aaz/latest/cognitiveservices/account/costcontrol/_list.py:166, src/foundry-cost-control/azext_foundry_cost_control/aaz/latest/cognitiveservices/account/costcontrol/_show.py:208, src/foundry-cost-control/azext_foundry_cost_control/aaz/latest/cognitiveservices/account/costcontrol/_update.py:118: A generated file changed without an open or merged Azure/aaz pull request containing the durable command-model change.
  Remediation: Make the durable command-model change in Azure/aaz, link that PR in this description, then regenerate the downstream aaz/<profile> output.
  Verify: Regenerate from a clean checkout and confirm the resulting diff contains this change and the linked source PR is open or merged.

Risk assessment — 66/100 · High · High confidence

The High rating is driven by public CLI behavior, dependency or supply chain, failure-handling behavior and 1 additional signal(s).

• Change scope: 11 changed files, 1593 changed lines (+834 / -759), including 5 production files.
• Affected components: foundry-cost-control
• Risk drivers: public CLI behavior (+18); dependency or supply chain (+18); failure-handling behavior (+12); generated output (+12)
• Regression evidence: Changed regression tests are included, reducing risk.
• Confidence: High because changed-line patches were available for every production file.
• Required review: Owning-squad review is required for foundry-cost-control before merge.

Posted by x-engineering-agent (Reviewer)

[Azure CLI Bot (azclibot)]

[Release] Update index.json for extension [ foundry-cost-control-1.0.0b3 ] : https://dev.azure.com/msazure/One/_build/results?buildId=186028058&view=results