Repository navigation
[Containerapp] BREAKING CHANGE: Change default logs destination to Azure Monitor - #10473
Michael Dai (michaelkira) wants to merge 3 commits into
Conversation
…ure Monitor Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Thank you for your contribution Michael Dai (@michaelkira)! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
🟡 Changes recommended
Logging tests still assume the old default and lack coverage verifying the new default through the CLI.
1 open finding
What changed in this PR
Changes the default logging destination for Container Apps environment creation to Azure Monitor.
Changes:
- Defaults
az containerapp env createtoazure-monitorwhile preserving explicit destination choices. - Documents the breaking change in release history.
| File | Description |
|---|---|
| src/containerapp/HISTORY.rst | Documents the breaking logging-default change. |
| src/containerapp/azext_containerapp/custom.py | Changes the environment-create default destination. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Hi Michael Dai (@michaelkira), |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Please fix CI issues |
Update registry resource request URIs to API 2026-09-01-preview while preserving server-returned operation polling URLs and all recorded responses. All 18 previously failing cassette tests pass. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Yong Zhang (@yonzhan) Fixed the reported CI failures in 5c490cb. All 18 failing tests were cassette mismatches caused by the current ACR SDK using Validation: reproduced the original failure locally, then replayed all 18 previously failing tests with The fix is pushed; the hosted Python 3.10–3.14 checks still need to complete on the new commit. |

🤖 PR Validation — ❌ Action needed
❌Azure CLI Extensions Breaking Change Test
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az containerapp env createDescription
Changes the default value of
--logs-destinationfromlog-analyticstoazure-monitorwhen creating a Container Apps managed environment. Explicit--logs-destinationvalues continue to work unchanged.This is a breaking change because callers that omit
--logs-destinationwill now create environments configured for Azure Monitor instead of Log Analytics. The breaking change is documented inHISTORY.rst.Testing
azdev style azext_containerapp- Passed (Pylint and Flake8).python scripts/ci/test_index.py -q- Passed (9 tests, 2 skipped).azdev test azext_containerapp.test_containerapp_env_default_logs_destination --profile latest --series --live --discover- Passed and generated the recording.azdev test azext_containerapp.test_containerapp_env_default_logs_destination azext_containerapp.test_containerapp_env_la_dynamic_json --profile latest --series- Passed in playback mode (2 tests).Pre-announcement dependency — hold implementation merge
az containerapp env create: Pre-announce future logs destination default change #10494az containerapp env create: Pre-announce future logs destination default change azure-cli#34243log-analyticsdefault.--logs-destination log-analytics:General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install azdevrequired)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.