Repository navigation
fix: protect reconcile labels on managed jobs and deployments - #1362
Merged
Britania Rodriguez Reyes (britaniar) merged 3 commits intoOct 12, 2026
Merged
Conversation
Signed-off-by: Arvind Thirumurugan <arvindth@microsoft.com>
Arvind Thirumurugan (Arvindthiru)
changed the title
Britania Rodriguez Reyes (britaniar)
previously approved these changes
Oct 9, 2026
…s/deployments Signed-off-by: Arvind Thirumurugan <arvindth@microsoft.com>
Arvind Thirumurugan (Arvindthiru)
changed the title
Britania Rodriguez Reyes (britaniar)
approved these changes
Oct 9, 2026
Britania Rodriguez Reyes (britaniar)
merged commit Oct 12, 2026
23641d7
into
Azure:main
37 of 40 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Add E2Es for #1360
Adds end-to-end coverage for Job mutating and validating webhooks and closes a label-removal bypass for managed Jobs and Deployments.
Prevents non-aksService users from removing both reconcile labels in one update.
Preserves existing behavior that blocks all non-aksService updates to reconcile-managed resources.
Adds Job webhook E2Es covering mutation, validation, updates, reserved namespaces, and Pod creation.
Verifies managed Jobs create labeled Pods and unmanaged Jobs cannot create Pods.
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer