Repository navigation
fix(ci): pin shared gallery lookup API - #936
Closed
Kevin Cho (chokevin) wants to merge 2 commits into
Closed
Kevin Cho (chokevin) wants to merge 2 commits into
Kevin Cho (chokevin) wants to merge 2 commits into
Conversation
Contributor
Author
|
Copilot resolve the merge conflicts in this pull request |
…ry-api-fix # Conflicts: # hack/agent/e2e-kind/e2e.py # hack/agent/e2e-kind/test_host_image.py Co-authored-by: chokevin <11001563+chokevin@users.noreply.github.com>
Contributor
Resolved the conflicts and merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure Container Linux host-image resolution started failing before VM provisioning because Azure CLI's
az sig image-version show-sharedselected unsupported Microsoft.Compute API version2026-03-03forlocations/sharedGalleriesinwestus2. The harness now resolveslatestthrough the same ARM resource withaz restpinned to supported API version2024-03-03, while preserving the existing optionalACL_IMAGE_SUBSCRIPTIONforwarding.This is a compatibility workaround for deterministic Azure CLI drift tracked in Azure/azure-cli#34229; upstream is reverting the regression in Azure/azure-cli#34232.
az account showto resolve the effective subscription, then URL-encodes each shared-gallery path component and requests the exactMicrosoft.Compute/locations/sharedGalleries/.../versions/latest?api-version=2024-03-03resource.acl_azbuilder, soACL_IMAGE_SUBSCRIPTIONis forwarded consistently.show-sharedlookup only from Azure Container Linux gallery-version resolution.show-shared.Evidence
agent e2e (host acl, nspawn azlinux3)before provisioning.Verification
cd hack/agent/e2e-kind && python3 -m unittest -v test_host_image.py(43 tests)COPYFILE_DISABLE=1 TMPDIR="$PWD/tmp/python-tests" python3 -m unittest discover -s hack/agent/e2e-kind -p 'test_*.py'(111 tests)python3 -m py_compile hack/agent/e2e-kind/e2e.py hack/agent/e2e-kind/test_host_image.pygit diff --checkRisk
The change is limited to CI host-image discovery. The primary risk is future ARM API retirement or a shared-gallery resource-shape change; the focused command/URL tests detect accidental drift, and reverting this commit restores the Azure CLI command once the upstream fix is available.
Non-goals