Repository navigation
racer: require pods to name their ClusterCache - #976
Merged
Merged
Conversation
Remove the implicit "racer-object" default ClusterCache name. The sidecar injector now denies opted-in pods that do not set the racer.unbounded-cloud.io/object-cache annotation, and racer-object fails at startup when --cache is not set. A pod can no longer attach to a cache it did not ask for just because one happens to be named racer-object.
Update the racer-object reference and the Azure Blob cache guide so pods always set racer.unbounded-cloud.io/object-cache and --cache has no default.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Static review found no blocking issues; validation, regression coverage, and documentation consistently enforce explicit cache selection.
No open issues 🎉
What changed in this PR
Removes the implicit racer-object ClusterCache default so workloads must explicitly select their cache, preventing accidental attachment to an unrelated cache.
Changes:
- Requires
object-cachefor sidecar injection and--cacheforracer-objectstartup. - Adds missing-cache regression cases and updates existing tests to specify a cache.
- Updates reference documentation and Azure Blob examples to show explicit cache selection.
| File | Description |
|---|---|
internal/racer/injector/injector.go |
Rejects missing cache annotations instead of applying a default. |
internal/racer/injector/injector_test.go |
Covers missing-cache denial and updates pod fixtures. |
docs/content/reference/racer-object.md |
Documents required cache selection and updates the example. |
docs/content/guides/azure-blob-cache.md |
Adds the required cache annotation to deployment instructions. |
cmd/racer-object/main.go |
Requires an explicit, nonempty --cache value. |
cmd/racer-object/main_test.go |
Tests required cache selection and updates command arguments. |
cmd/racer-object/azure_test.go |
Supplies explicit cache arguments in provider tests. |
Review effort: Balanced
Jordan Olshevski (jveski)
marked this pull request as ready for review
October 22, 2026 15:05
Jordan Olshevski (jveski)
enabled auto-merge
October 22, 2026 15:05
Vaibhav Patel (vpatelsj)
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the implicit
racer-objectdefault ClusterCache name. Pods that opt in to the racer-object sidecar must now set theracer.unbounded-cloud.io/object-cacheannotation, and the injector webhook denies them if it is missing.racer-objectalso fails at startup when--cacheis not set. This stops a pod from silently attaching to a cache that happens to be namedracer-object. Docs are updated to match.