docs: say that verify, proxies and timeout do not apply to a custom http_client - #961
Open
Max Azatian (HardMax71) wants to merge 1 commit into
Open
docs: say that verify, proxies and timeout do not apply to a custom http_client#961Max Azatian (HardMax71) wants to merge 1 commit into
Max Azatian (HardMax71) wants to merge 1 commit into
Conversation
…ttp_client Each of the three parameters already carries that note; the http_client paragraph itself did not, so a reader of it could miss it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #960
Docs only. Adds one sentence to the
http_clientparagraph ofClientApplication.__init__: theverify,proxiesandtimeoutparameters configure only the default session, so a custom http_client has to carry them itself. Each of the three parameters already says so on its own entry; this makes it visible from thehttp_cliententry too, which is the one a reader looks at when deciding whether to pass a client.No behaviour change.
import msaland the built docstring checked locally.