Repository navigation
test: make B2Json Container.equals check all fields and test the version-range upper bound - #229
Open
ffumero2003 wants to merge 1 commit into
Open
ffumero2003 wants to merge 1 commit into
ffumero2003 wants to merge 1 commit into
Conversation
…ion-range upper bound Compare the serialized-name field during Container equality checks and provide a matching hash code. Exercise version 6 in the version-range upper-bound case.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Two test-quality gaps in
B2JsonTest.Changes
Container.equals/hashCodenow include thedfield. The test helper'sequalscompared onlyaandb, so a round-trip test of escaped names (@d) was vacuous — twoContainers differing only indwere "equal". The escaped-name test now asserts the decodedddirectly and that aContainerdiffering only indis unequal.setVersion(4), so version 6 was never tested; it now usessetVersion(6).Verification
./gradlew :b2-sdk-core:test --tests com.backblaze.b2.json.B2JsonTestpasses; the full build passes. RevertingContainer.equalsto ignoredmakes the escaped-name test fail; restoring it passes.