chore(deps): support symfony 7 - #3
Merged
Merged
Conversation
Widens the Symfony constraints to `^6.4 || ^7.0` and raises the PHP floor to 8.2, which is what Symfony 7 needs. The bundle code was already compatible: the extension extends the DependencyInjection `Extension` (not the moved HttpKernel one), the listener uses `ResponseEvent`/`isMainRequest()`, and services are declared through `ContainerConfigurator`. Three things had to be fixed to get CI green, all caused by the unpinned dev dependencies that `composer update` resolves to their latest: - phpcs has been failing on main since slevomat 8.x renamed the `DeclareStrictTypes` properties to `linesCount*`. - the blanket `@phpstan-ignore-next-line` in `Configuration` is unmatched on Symfony 7, where `getRootNode()` is documented as returning an `ArrayNodeDefinition`. Replaced with an explicit assert. - the test matrix now runs 8.2/8.3/8.4, but only pairs `--prefer-lowest` with 8.2: the lowest allowed Symfony brings in a symfony/cache that is not PHP 8.4 clean, and no consumer will ever hit that combination. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Teddy Sommavilla (wazazaby)
marked this pull request as ready for review
September 21, 2026 15:35
Member
Author
|
Supersedes #2 and answers #1: yes, Symfony 7 support was planned, sorry it took a while. This does the same constraint widening as Raphaël Droz (@drzraf)'s patch, with a few differences: the floor moves to Thanks for the nudge and the patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Élargit les contraintes Symfony à
^6.4 || ^7.0et monte le plancher PHP à 8.2, ce qu'exige Symfony 7. Le code du bundle était déjà compatible : l'extension étend leExtensionde DependencyInjection (pas celui de HttpKernel qui a bougé), le listener utiliseResponseEvent/isMainRequest(), et les services passent parContainerConfigurator.Trois choses à corriger pour avoir une CI verte, toutes dues aux dev dependencies non pinnées que
composer updaterésout au dernier :maindepuis que slevomat 8.x a renommé les propriétés deDeclareStrictTypesenlinesCount*@phpstan-ignore-next-lineglobal dansConfigurationn'est pas matché en Symfony 7, oùgetRootNode()est documenté comme renvoyant unArrayNodeDefinition. Remplacé par un assert explicite--prefer-lowestqu'avec 8.2 : le Symfony le plus bas autorisé tire un symfony/cache qui n'est pas PHP 8.4 clean, et aucun consommateur ne tombera jamais sur cette combinaisonÀ taguer
2.1.0(les tags existants n'ont pas de préfixev, contrairement aux liens du CHANGELOG qui pointaient versv1.1.1). Packagist le récupère via le webhook. Le CHANGELOG récupère au passage l'entrée 2.0.0 qui manquait.🤖 Generated with Claude Code
Closes #1