Repository navigation
chore: Alloy v1.21.0 도입 및 filelog 정렬 통일 #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
geonusp
wants to merge
6
commits into
main
Choose a base branch
from
chore/alloy-v1.21.0-adoption-direct
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c888840
chore: Alloy 이미지 v1.21.0 업그레이드
geonusp c45e698
chore: Alloy 파일 정렬 기준을 alphabetical로 통일
geonusp 2dcaa98
test: Alloy 회전 로그 정렬 순서 검증 추가
geonusp 3735943
chore: 민감한 로컬 파일 제외 규칙 추가
geonusp 5c5e3b7
fix: Alloy 검증 설정 파일 읽기 권한 수정
geonusp 19c3a5f
docs: Alloy 로그 정렬 설정 설명 갱신
geonusp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
block : 기존 버전에서 업그레이드할 때 저장된 읽기 위치를 이어받도록 보완해 주세요.
기존
file_input을 제거하면서 입력기 ID가docker_files에서 기본값인file_input으로 바뀌어, 같은 볼륨을 사용해도 기존 읽기 상태를 찾지 못합니다. 실제로 v1.19.2에서 로그를 수집한 뒤 파일과 상태 저장 디렉터리를 유지한 채 이번 설정으로 전환하니, 이미 수집한 로그를 처음부터 다시 읽고 출력했습니다.현재 테스트는 새 버전에서의 재시작만 확인하므로, 기존 버전에서 수집한 상태로 업그레이드해도 이전 로그를 다시 보내지 않는지 검증하는 테스트도 추가해 주세요.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
기존 읽기 상태와의 하위 호환성이 필요한 상황이 있다는 점에는 동의합니다. 다만 이번 변경은 운영 중인 Alloy를 업그레이드하는 작업이 아니며, 서비스 중단 후 이전 상태를 복원해 재개할만큼의 유의미한 데이터도 없습니다. 그러므로 이번 변경에서는 기존 v1.19.2가 저장한 읽기 위치와의 호환성 및 마이그레이션 테스트를 범위에 포함하지 않겠습니다.