Repository navigation
Conversation
AI-assisted-by: Codex
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the focused RightClickHarvest slice from #76, stacked on #87. The opt-in effect supports wheat, potatoes, carrots, beetroot and nether wart. Main-hand mature-crop admission and deferred execution recheck interaction permission, player session, slot/tool/seed, crop state, range, loaded region and perk eligibility. Shared AutoPlant restrictions apply; the guarded native break retains protection, tool wear, normal drops and Farmer bonuses without duplicate AutoPlant or recursive automation.
The parent ledger confirms a personal usage reservation before one exact inventory seed is deducted. A completed native break and age-zero replant is one successful use. Proven-unused work releases its reservation; false/throwing native calls and changed replacement/reload/replant outcomes remain uncertain, keep the seed and charge spent, and never automatically replay. Existing perk defaults remain unchanged. PrecisionMode, queues, banking and statistics remain separate slices.
Validation: 58 harvest cases include all original five-crop/15 admission controls plus protection, stale contexts, duplicates, native uncertainty, reload and Farmer integration. A clean package passed 479 tests with zero failures/errors/skips, retaining all 421 parent test identities. Source and execution context stayed unchanged. All 30 suites selected the expected 75 dependency JARs; ZIP integrity, unique entries, 40 resources, filtered descriptor, Java 21 classes and test/provided-library exclusions passed. JAR SHA-256: e20463dd5140ab56b5680d5383883b85559c374a91f57ebf0e3f440ade78e11e.
Fresh independent read-only review of the complete frozen six-file P5 change returned No findings. Exact source/argument privacy checks and native generated commit-metadata verification precede branch publication.
Remains draft for normal dependency delivery, compatibility coordination, current-head hosted feedback and separately authorized native/older-server acceptance. Validation used isolated candidate dependencies, not released artifacts. Mocked-world unit tests are not native protection-plugin acceptance. MCPerks does not declare Folia support. Merge order is #78, #80, #86, #87, then this slice. No merge, release or deployment is included.
Created with AI assistance.