Repository navigation
fix: 修复图片主题被原生容器遮挡及上下状态栏对比度 - #2563
Open
JasirVoriya wants to merge 1 commit into
Open
JasirVoriya wants to merge 1 commit into
JasirVoriya wants to merge 1 commit into
Conversation
JasirVoriya
marked this pull request as ready for review
October 16, 2026 06:02
This was referenced Oct 16, 2026
Open
BigPizzaV3
approved these changes
Oct 16, 2026
BigPizzaV3
left a comment
Owner
There was a problem hiding this comment.
代码审核通过。新增规则均限制在主题启用、图片就绪且宽幅 ambient/banner/full 模式;透明化只作用于指定宿主主容器,上下栏继续使用主题颜色,未发现需要修改的代码问题。
独立验证:主题前端测试 22 项、Rust assets 测试 7 项通过,包含新增的范围约束测试。合并前请确认当前 head 的 Windows/macOS CI 均通过。
本 PR 与 #2566 同时修改运行时 revision 和对应测试断言。建议先合 #2566,再将本 PR rebase,保留这次壁纸兼容规则并统一提升 revision,重跑新 head CI。
发布前已再次核对当前提交的 CI run 38857979920:macOS DMG (universal):通过;Windows artifacts:运行中。 当前仅批准代码,最终合入仍须双平台CI成功。
Owner
|
合入状态更新:#2566 已进入 main( 请按前次评审约定完成 rebase,保留本 PR 的壁纸兼容规则并统一 runtime revision;新 head 需要重新跑 Windows artifacts 和 macOS universal DMG。 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题与修复
Closes #2562
macOS 新版 Codex 中,宽幅图片已加载到
body,但_PageSurfaceLayout_*/main._MainContentSurface_*的不透明底色将其遮住。恢复图片后,顶部标题栏在明亮壁纸区域的文字和图标对比度不足。@layer theme内的!important,正确覆盖原生分层 CSS 的优先级。验证
git diff --check通过。rgba(29, 29, 30, 0.68)。随后恢复本地用户脚本。CARGO_PROFILE_TEST_DEBUG=0 CARGO_INCREMENTAL=0 cargo test -p codex-plus-core --lib assets::tests --locked -j 1(7 passed)。crates/codex-plus-data/src/provider_sync.rs:4490的file.try_lock()?处遇到 E0658(file_lock)/ E0277(TryLockError不能转换为std::io::Error)。本机工具链为 rustc 1.88.0;已确认基线 main 含相同代码。因此未能完成桌面二进制构建和本地实例启动,未将其标为通过。cargo fmt --all -- --check存在当前 main 的既有格式差异,本 PR 未重排无关文件。未执行 Codex 重启验证,未上传包含私人聊天列表的全屏截图。