Skip to content

Ignore unknown .env keys in Settings so COMPOSE_PROFILES works - #188

Merged
maximusunc merged 1 commit into
develfrom
claude/funny-davinci-kiosfz
Oct 27, 2026
Merged

maximusunc merged 1 commit into
develfrom
claude/funny-davinci-kiosfz

Conversation

@maximusunc

Copy link
Copy Markdown
Collaborator

The .env file is read by both docker compose and pydantic-settings, so compose-only keys like COMPOSE_PROFILES=ars made Settings() fail on extra fields. Also moves to the pydantic v2 SettingsConfigDict style.

Claude-Session: https://claude.ai/code/session_01S2yuRBGxBxmZVnvyqujYv2

The .env file is read by both docker compose and pydantic-settings, so
compose-only keys like COMPOSE_PROFILES=ars made Settings() fail on
extra fields. Also moves to the pydantic v2 SettingsConfigDict style.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01S2yuRBGxBxmZVnvyqujYv2
@maximusunc
maximusunc merged commit 6c9f5bc into devel Oct 27, 2026
2 checks passed
@maximusunc
maximusunc deleted the claude/funny-davinci-kiosfz branch October 27, 2026 15:16
@codecov

codecov Bot commented Oct 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.54%. Comparing base (5cb916c) to head (3989423).
⚠️ Report is 3 commits behind head on devel.

Files with missing lines Coverage Δ
shepherd_utils/config.py 98.74% <100.00%> (-0.01%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24a0bcc...3989423. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

maximusunc pushed a commit that referenced this pull request Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants