Skip to content

Score paths embeddings v2 - #189

Merged
maximusunc merged 5 commits into
develfrom
score-paths-embeddings-v2
Oct 28, 2026
Merged

maximusunc merged 5 commits into
develfrom
score-paths-embeddings-v2

Conversation

@uhbrar

@uhbrar uhbrar commented Oct 27, 2026

Copy link
Copy Markdown
Collaborator

Uses a smaller embeddings database (which has no effect on scores, just makes the database slight smaller and faster to read). Also fixes a bug when scoring paths from a scublass node, which caused misses, and preloads search graph into the pathfinder worker so the first query after worker restart doesn't time out the search.

@uhbrar
uhbrar requested a review from maximusunc October 27, 2026 21:42
@codecov

codecov Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 65.21739% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.54%. Comparing base (3989423) to head (f25b8e8).
⚠️ Report is 1 commits behind head on devel.

Files with missing lines Patch % Lines
workers/aragorn_pathfinder/worker.py 11.11% 8 Missing ⚠️
Files with missing lines Coverage Δ
shepherd_utils/data_download.py 83.03% <ø> (ø)
workers/score_paths/scorer.py 98.26% <100.00%> (+0.35%) ⬆️
workers/score_paths/worker.py 60.00% <ø> (ø)
workers/aragorn_pathfinder/worker.py 81.79% <11.11%> (-1.59%) ⬇️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c9f5bc...f25b8e8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maximusunc

Copy link
Copy Markdown
Collaborator

The subclass fix uses a broad signal. Any edge with a biolink:support_graphs attribute is treated as “inferred” and pushed behind the pair’s own edges. The docstring talks about Gandalf subclass inference, but this also catches other inferred or creative-mode edges and anything merged with support graphs (merge_message/worker.py:130 adds that attribute). If the reranker’s training paths only excluded subclass-inferred edges, this may hide legitimate inferred predicates when a direct edge exists. Please confirm that matches training. The new test covers the intended cases well, including “negated own edge falls back to inferred”.

@maximusunc
maximusunc merged commit d171222 into devel Oct 28, 2026
2 checks passed
@maximusunc
maximusunc deleted the score-paths-embeddings-v2 branch October 28, 2026 20:41
maximusunc pushed a commit that referenced this pull request Oct 29, 2026
ARS payload store and retention, Redis/monitor hardening, score_paths v2
embeddings, Omnicorp decimal shared counts: TRAPI-neutral, taken as is.

#194 removes the seven shared-regulator treats rules from ARAGORN's rules
file, which this branch keeps in its TRAPI 1.x query shapes: the same seven
rules (matched by their Rule text) are removed from the 1.x file, leaving the
same 11 treats rules in the same order; the rest of the file is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TtsBikU9y9AFQ5uu9tcioz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants