Skip to content

fix(statics): lowercase tbaseeth:waBasSepLidUSDC symbol - #9740

Merged
sachinBitgo merged 1 commit into
masterfrom
sachinroy936/defi-802-fix-token-name-casing
Sep 15, 2026
Merged

sachinBitgo merged 1 commit into
masterfrom
sachinroy936/defi-802-fix-token-name-casing

Conversation

@sachinBitgo

@sachinBitgo sachinBitgo commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Renames the DEFI-802 test token symbol from tbaseeth:waBasSepLidUSDC to tbaseeth:wabasseplidusdc (lowercased, same name otherwise)
  • The mixed-case symbol broke IMS's admin balance-resync path: ConsolidateTokenBalanceEventPayload.checkTokenValue() lowercases the token name before comparing it against the AMS-sourced supported-token map (which preserves original casing), so any symbol with uppercase letters fails the check and resync silently fails

Dependency chain

This is one of three coordinated PRs (this repo's statics rename, asset-metadata-service's bitgo_symbol rename, and a wallet-platform config update that depends on this being published first).

Test plan

  • coins.get('tbaseeth:wabasseplidusdc') resolves correctly
  • No remaining references to waBasSepLidUSDC (mixed-case) in statics source

Ticket: DEFI-802

@sachinBitgo
sachinBitgo requested a review from a team as a code owner September 15, 2026 14:02
@linear-code

linear-code Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

DEFI-802

@github-actions

github-actions Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

⚠️ Unit tests are failing on Node 26.x (Current release line, non-blocking). This is not an LTS version yet, so it does not block merge, but it signals an incompatibility to fix before Node 26.x becomes LTS.

View run

…usdc

The mixed-case token symbol broke IMS's admin resync path: it lowercases
the token name before matching it against the AMS-sourced supported-token
map, which preserves original casing. Any symbol containing uppercase
letters fails that check, causing balance resync to silently fail.

Renaming to an all-lowercase symbol side-steps the bug.

Ticket: DEFI-802
@sachinBitgo
sachinBitgo force-pushed the sachinroy936/defi-802-fix-token-name-casing branch from 619dc7e to 8005e51 Compare September 15, 2026 14:28
@sachinBitgo sachinBitgo changed the title fix(statics): rename tbaseeth:waBasSepLidUSDC to tbaseeth:wausdc fix(statics): lowercase tbaseeth:waBasSepLidUSDC symbol Sep 15, 2026
@sachinBitgo
sachinBitgo merged commit 53f733a into master Sep 15, 2026
39 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants