fix(abstract-eth): preserve zero wallet version for CCR - #9742
Draft
ralph-bitgo[bot] wants to merge 1 commit into
Draft
ralph-bitgo[bot] wants to merge 1 commit into
ralph-bitgo[bot] wants to merge 1 commit into
Conversation
Pass wallet version zero from cross-chain recovery build responses into the transaction builder and cover legacy CCR signing responses in EthLike tests.\n\nWithout this, a version-zero wallet is treated as missing during recovery signing, so self-serve CCR signing can produce an invalid transaction for affected customer funds.\n\nTicket: SPT-452 Session-Id: 43a697ad-f056-41b1-855b-c82224af5734 Task-Id: 72246e14-040e-4132-9fef-4e56482d1b19
ralph-bitgo
Bot
force-pushed
the
SPT-452-self-serve-ccr-signing
branch
from
September 15, 2026 17:37
8b80f56 to
6d1674b
Compare
Contributor
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
0when rebuilding EthLike cross-chain recovery transactionsWhy
Version-zero wallets are valid legacy CCR wallets. Treating
0as absent drops the wallet version during self-serve recovery signing and can produce an invalid transaction, blocking customer fund recovery.Verification
BITGOJS_TEST_PASSWORD=test yarn unit-test --grep 'cross chain recovery'inmodules/sdk-coin-ethlike— 15 passingyarn buildfor@bitgo/abstract-ethand@bitgo/sdk-coin-ethlikeTicket: SPT-452