fix(pending-approval): cancel pending approvals - #9748
Draft
ralph-bitgo[bot] wants to merge 1 commit into
Draft
ralph-bitgo[bot] wants to merge 1 commit into
ralph-bitgo[bot] wants to merge 1 commit into
Conversation
Route cancellation requests to the pending approval cancel API and send the canceled state from both SDK implementations. Extend the V2 response contract and add endpoint and SDK coverage. This preserves rejection semantics while allowing pending transactions to be canceled explicitly instead of being reported as rejected. Ticket: WCI-1631 Session-Id: 8aad1ca5-334f-4dee-a4e7-bd8cd69a92e3 Task-Id: c637ca13-8d29-4521-b341-6bf9a94fbc44
ralph-bitgo
Bot
force-pushed
the
WCI-1631-cancel-pending-transactions
branch
from
September 16, 2026 09:36
7b8c37b to
c3d88f5
Compare
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
canceledpending-approval state to the SDK model and V2 response contract.PendingApproval.cancel().state: canceledinstead of aliasing cancellation to rejection.Why
Pending transactions need a distinct cancellation path so callers can cancel them without incorrectly reporting them as rejected. Rejection behavior remains unchanged for all other non-approval states.
Test plan
nix develop . --command yarn lerna run build --streamTicket: WCI-1631