Repository navigation
Release locally in one command; make the CI release manual - #9
Conversation
Releases are cut from a Mac that already holds the Developer ID certificate and notarization profile, so GitHub needs no signing secrets. Add --publish to scripts/release.sh (tags origin/main and publishes the GitHub release, refusing dirty or stale checkouts and existing tags), and change the release workflow to run only when started by hand.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a8b03c7122
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ASC_KEY_ID: ${{ secrets.ASC_KEY_ID }} | ||
| ASC_ISSUER_ID: ${{ secrets.ASC_ISSUER_ID }} | ||
| run: scripts/release.sh "${GITHUB_REF_NAME}" | ||
| run: scripts/release.sh "${{ inputs.tag }}" |
There was a problem hiding this comment.
When a write-level user dispatches this workflow with an existing tag containing shell syntax such as $(...)—which is valid in a Git ref—GitHub interpolates the input before the shell parses this line, and the surrounding double quotes do not prevent command substitution. Arbitrary commands can therefore run while the App Store Connect key and unlocked signing keychain are available; the direct interpolation is repeated at line 65 while GH_TOKEN is present. Pass the expression through an env entry and reference the resulting shell variable instead.
Useful? React with 👍 / 👎.
| git tag -a "v$VERSION" -m "PR Monitor $VERSION" | ||
| git push -q origin "v$VERSION" | ||
| gh release create "v$VERSION" "$DIST/PRMonitor.dmg" "$DIST/PRMonitor.zip" "$DIST/SHA256SUMS" \ |
There was a problem hiding this comment.
If the tag push succeeds but gh release create then fails because of a transient network or asset-upload error, the next invocation fetches that tag and exits at the existing-tag guard before it can retry publication. This is particularly plausible because gh release create --help documents creation, asset upload, and publication as separate API calls. The advertised one-command flow can thus leave a remote tag or draft without a usable release; permit reuse when the existing tag resolves to the current origin/main commit and resume the release operation.
Useful? React with 👍 / 👎.
1 participant
Releases are cut from your Mac, which already has the Developer ID certificate and the
PRMonitornotarization profile, so GitHub doesn't need any signing secrets.scripts/release.sh <version> --publishbuilds, signs, notarizes and staples, then tagsorigin/mainand publishes the GitHub release. It refuses to publish from a dirty or stale checkout, or to reuse an existing tag.release.ymlnow runs only when started by hand (workflow_dispatch), so pushing a tag no longer starts a run that fails for lack of secrets.docs/RELEASING.mddocuments the local flow as the standard path, with the CI secrets moved to an optional section.Tested: both guards reject bad invocations before building (dirty checkout, unknown option). The build steps are unchanged from the flow that shipped v1.0.0.