Repository navigation
types: keep the builtin alias in ResolvedType - #443
Merged
apoelstra merged 3 commits intoOct 17, 2026
Merged
Conversation
KyrylR
approved these changes
Oct 16, 2026
KyrylR
left a comment
Collaborator
There was a problem hiding this comment.
ACK d600cac; successfully ran local tests
note on metadata retention: when a parameter's first analysed use carries the plain structural annotation, a later Pubkey-typed or jet-inferred use does not update the stored tag, including nested array elements
There are two small follow-ups from what I can see:
- Fix a note above, it is non-blocking for this PR imo
- Also noticed that we have a stale README nominal-typing sentence in
src/types/README.md:20, also can be fixed later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When types are resolved, builtin aliases turn into their underlying types:
Pubkey,FeandScalarbecomeu256, andPointbecomes(u1, u256). SoAbiMetacan't tell a public key from an arbitrary 256-bit number.Simplex needs this information for correct, strongly typed
include_simfexpansion and simplified fuzz value generation. Its entire inner structure depends on values derived from theResolvedTypesinAbiMeta.Also added minor refactoring in
types/README.mdmissing from ast refactoringChecklist
examples/kitchen_sink.simf, andtest-data/kitchen_sink.jsonisregenerated.