Repository navigation
tests: always build tests with the serde feature - #446
Open
stringhandler wants to merge 1 commit into
Open
stringhandler wants to merge 1 commit into
stringhandler wants to merge 1 commit into
Conversation
Tests that read witness or argument files needed a cfg(feature = "serde") gate, so `cargo test --no-default-features` skipped 52 of them. Make the crate a dev-dependency of itself with serde enabled, so every test build has serde, and drop serde from the 30 test-only cfg attributes. The library and simc still build without serde; CI checks that with `cargo build --no-default-features` and cargo hack. Assisted-by: Claude
Contributor
|
Personally I think we should just make |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a weird non-serde feature set in simc. This makes writing tests that read and write data difficult.
I can't see a place where we would be worried about having serde in the tests, but if there is one, I'm happy to close this pr.
LLM description below:
Tests that read witness or argument files needed a cfg(feature = "serde") gate, so
cargo test --no-default-featuresskipped 52 of them. Make the crate a dev-dependency of itself with serde enabled, so every test build has serde, and drop serde from the 30 test-only cfg attributes.The library and simc still build without serde; CI checks that with
cargo build --no-default-featuresand cargo hack.Assisted-by: Claude
Checklist
examples/kitchen_sink.simf, andtest-data/kitchen_sink.jsonisregenerated.