Skip to content

Getters for script hash - #69

Merged
aritkulova merged 5 commits into
devfrom
feat/script-hash-getters
Oct 20, 2026
Merged

Getters for script hash#69
aritkulova merged 5 commits into
devfrom
feat/script-hash-getters

Conversation

@aritkulova

@aritkulova aritkulova commented Oct 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • This PR suggests a bug fix and I've added the necessary tests.
  • This PR introduces a new feature and I've discussed the update in an Issue or with the team.
  • This PR is just a minor change like a typo fix.

@aritkulova aritkulova self-assigned this Oct 16, 2026
@aritkulova
aritkulova requested a review from LesterEvSe October 19, 2026 09:22
LesterEvSe
LesterEvSe requested changes Oct 19, 2026
View reviewed changes
Comment thread simf/lib/utxo/getters/script_hash.simf
Comment thread simf/lib/utxo/getters/script_hash.simf Outdated
Comment thread simf/lib/utxo/getters/script_hash.simf Outdated
Comment thread tests/stdlib/common/core.rs Outdated
Comment thread tests/stdlib/common/core.rs Outdated
Comment thread tests/stdlib/common/utxo_helper.rs Outdated
Comment thread tests/stdlib/common/core.rs Outdated
Comment thread docs/stdlib.json Outdated
@aritkulova
removed get_current_script_hash;
744ee6e 
minor refactoring;
fixed typos
@LesterEvSe

LesterEvSe commented Oct 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

I see you've added an entry to CHANGELOG.md, but I think it should be organized a bit differently: the versions in this file and in Cargo.toml need fixing. And since 0.2.0 hasn't been released yet let's move it to [Unreleased] block

LesterEvSe
LesterEvSe reviewed Oct 20, 2026
View reviewed changes
Comment thread Cargo.toml Outdated
@aritkulova
aritkulova force-pushed the feat/script-hash-getters branch from 017e573 to f3dcf8c Compare October 20, 2026 10:28
@aritkulova
aritkulova requested a review from LesterEvSe October 20, 2026 11:16
LesterEvSe
LesterEvSe approved these changes Oct 20, 2026
View reviewed changes

@LesterEvSe LesterEvSe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aritkulova
aritkulova merged commit d0829f7 into dev Oct 20, 2026
2 checks passed
@aritkulova
aritkulova deleted the feat/script-hash-getters branch October 20, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LesterEvSe LesterEvSe LesterEvSe approved these changes

Assignees

@aritkulova aritkulova

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aritkulova @LesterEvSe