Repository navigation
Conversation
…eat/sdk-fixes Feat/sdk fixes
…eat/smarter-fuzzing Smarter fuzzing
* add errors instead of panic * add additional tests to catch this behaviour
fix: * hash collisions on deps installation * overlapping cloning behaviour (tag and branch) * dependency escaping issue
…ix/issues Fix inconsistency in SDK
…ix/findings Fix/findings
Describe what each part of `FinalTransaction` does rather than restating signatures: input and output order, what the signer adds, how the transaction-wide sequence and locktime reach each input, how the default sequence enforces a locktime, the change target's blinding rule, and what `is_balanced`, `calculate_fee_delta` and `extract_pst` count and return. Also document the witness path syntax of `ProgramSignature::at_path` and its errors, the issuance and reissuance entropy arguments, derivation path form, and the receipt's wait behavior, and add a module overview. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what each part of
FinalTransactiondoes rather than restating signatures: input and output order, what the signer adds, how the transaction-wide sequence and locktime reach each input, how the default sequence enforces a locktime, the change target's blinding rule, and whatis_balanced,calculate_fee_deltaandextract_pstcount and return.Also document the witness path syntax of
ProgramSignature::at_pathand its errors, the issuance and reissuance entropy arguments, derivation path form, and the receipt's wait behavior, and add a module overview.