Repository navigation
Unify mobile cloud navigation, compact drawer and connection names - #2170
Merged
Merged
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
⛔ Files ignored due to path filters: 78
📒 Files selected for processing: 46
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
Workspace navigation tracer checkpoint (UAT only, no merge):
|
This was referenced Oct 18, 2026
Contributor
Author
|
Follow-up at
|
Contributor
Author
|
Batch 22 native UAT completed; the shared Simulator window is released. No Prod or merge.
Evidence and full limits. Runtime CI39104178457 passed; fresh evidence-head CI39108117819 passed every applicable check. The wider collaboration goal and issue #2161 remain open. |
Issue: #2171 Agent-Task: codex/local/01a148ae-ec7f-74b2-8157-961411ce54c9
Issue: #2171 Agent-Task: codex/local/01a148ae-ec7f-74b2-8157-961411ce54c9
Issue: #2171 Agent-Task: codex/local/01a148ae-ec7f-74b2-8157-961411ce54c9
Issue: #2171 Agent-Task: codex/local/01a148ae-ec7f-74b2-8157-961411ce54c9
Issue: #2171 Agent-Task: codex/local/01a148ae-ec7f-74b2-8157-961411ce54c9
…cal names (#2175) * feat(mobile): separate computer and cloud drawer tabs Issue: #2174 Agent-Task: codex/local/01a148ae-ec7f-74b2-8157-961411ce54c9 * docs: attach native drawer tabs screenshots Issue: #2174 Agent-Task: codex/local/01a148ae-ec7f-74b2-8157-961411ce54c9 * fix(mobile): make drawer additions category-specific (#2174) Agent claim: #2174 (comment) * fix(mobile): keep contextual add directly below drawer tabs (#2174) * fix(mobile): retain native tab bounds for accessibility (#2174) * fix(mobile): keep drawer escape container separate from tabs (#2174) * fix(mobile): expose iOS segmented tabs as selected buttons (#2174) * feat(mobile): compact connection rows and pin drawer footer (#2174) Allow local names during pairing and verified cloud import, with cloud rename preserving trusted scope and sessions. Agent claim: #2174 (comment) * fix(mobile): keep drawer footer inside panel (#2174) * docs(mobile): capture compact drawer and naming evidence (#2174)
This was referenced Oct 18, 2026
Unify mobile drawer headers with iOS glass titles
DoodleBears
changed the title
DoodleBears
marked this pull request as ready for review
October 18, 2026 11:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloud navigation umbrella #2161 | Integration claim
Completed header slice #2171 | Remaining acceptance #2186
Compact drawer issue #2174 | Agent claim
Why the change
Let people switch between local computers and authorized cloud workspaces through a compact drawer, while channel-only guests see only their invited conversations.
Special things to note
config.name; Host identity, organization names, credentials and trusted discovery remain unchanged. Organization creation stays in cloud service management.dc15ffd3a; final native layout uses integrated1376b50b1. Naming save/restart/restore was verified atf2d0f4af3with identical naming code. Android, physical phone, VoiceOver, signed-in org/guest rows and real named-computer pairing remain unverified. The previously observed Pair-modal → cloud-services drawer-overlay issue remains open; no full navigation acceptance is claimed. Task:codex/local/01a148ae-ec7f-74b2-8157-961411ce54c9.Change outline
Merged into main as
9e73993308cf01e5d89f1be9a504ca657166aefaafter the passing integration checks below. CodeRabbit was still pending at merge time and is not claimed as review approval. No release or production deployment.Final current-main candidate:
4c4e4f079a4f457ca122694427b1bf5c48346575. Mobile suite: 690 passed / 8 skipped, typecheck, format and diff checks passed. Main advanced with #2109 during review; the sole root-layout conflict was resolved by retaining both HostDrawer and AppDialogHost, including the new Android dialog routing. Fresh integration CI 39125683378 passed every applicable job; the preceding candidate passed CI 39125050125. Earlier screenshots retain their source-bound status; the combined overlay interaction still requires native acceptance in #2186.Prior UAT native member/guest navigation, sibling denial, revoke, refresh/draft and isolated logout evidence remains at
bfb5cc4ecin the workspace record. It is not a fresh runtime pass of the integration candidate. Service companions TOB #25/#26 remain separately managed and UAT-only.Default text uses at most two lines per connection; accessibility text can wrap. Tabs do not change a Host or membership. Swipe/backdrop/Android Back/accessibility escape replace the redundant X; iOS tabs use selected-button semantics to avoid a verified native accessibility target-grouping failure. A duplicate footer in the backdrop was caught during native review and removed before final capture.
Native drawer comparisons — 402 × 874, English
Before is the preceding title/X + mixed Add iteration (
59fc97fd7), not the PR base. Both captures use the same empty Computer directory and signed-out UAT cloud configuration. Theme/viewport/locale match; the small exposed underlying route differs, so compare the drawer itself. Original PR-base evidence is retained in the older evidence directory.Computers — light, before / after
Cloud — light, before / after
Computers — dark, before / after
Cloud — dark, before / after
Connect with a local name
Computer pairing adds an optional name before scanning/pasting. The old pairing entry is the before state; native input was exercised without redeeming a pairing. Cloud renaming was saved, survived a cold restart, then the exact original name was restored and read back. These naming screenshots use
f2d0f4af3; the final correction only removed the duplicated backdrop footer.Maximum text — independent list scroll
The middle list exposes the address after a swipe while Notifications remains at the same position. This checks reachability, not a full VoiceOver or accessibility acceptance.
Full source-bound screenshots, checks and limits. Shared Simulator/Metro released, original cloud name and display settings restored. The recorded native run made no login, invitation acceptance, Host or Prod changes. Integration is now authorized; outstanding acceptance is tracked in #2186.
Generic Sheet header retained from #2171
Workspace title/X is superseded by tabs. Generic bottom Sheet retains the left-aligned title, optional icon and independent close action; iOS uses glass with opaque fallback and Android a plain title. Settings SheetStack remains outside this slice.
Header evidence was captured at runtime
4185d28a3; final #2172 head4c6acb7epassed CI39117869759. Historical screenshots are not a fresh native run of the integration.