Skip to content

fix(mobile): simplify Chats row menus and align gutters - #2589

Merged
DoodleBears merged 1 commit into
mainfrom
t3/chat-row-context-actions
Oct 22, 2026
Merged

DoodleBears merged 1 commit into
mainfrom
t3/chat-row-context-actions

Conversation

@DoodleBears

@DoodleBears DoodleBears commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Issue #2588 · Task claim · Follow-up to merged #2552 / #2519

Why the change

Chats rows give conversation details more room by moving the full action menu to long press while keeping swipe, screen-reader actions and the iOS preview, with consistent horizontal gutters.

Special things to note

  • Validation: source-only candidate on main cd38a528eff629611977eb80133e5aaae2e4b82c, including feat(mobile): swipe Chats rows and create Host sections #2552 and fix(mobile): keep Chats titles and timestamps inline at large text #2554. Existing formatter checks on touched non-ignored files and git diff --check passed; no local install, tests, typecheck, build, Host, Metro or device run. Focused behavioral coverage is prepared for CI and the assigned test center. No prior test result qualifies this head.
  • Merge risk: two-way door, medium blast radius. Reverting restores the permanent overflow column; no Host API, persistence or operation semantics change. Review iOS preview/context-menu coexistence, Android long press, Mark as read and accessibility availability. fix(mobile): keep Chats titles and timestamps inline at large text #2554 text layout is retained; pinned-grid/organization and unpin-on-assign changes are excluded. The old gutter stash remains separate and unchanged.
  • Native evidence is deferred under explicit Human authorization. No new clipping/geometry or interaction pass is claimed. Required checks: fully-open three-action bounds and ancestor clipping versus hit regions, header glyph/avatar visible edges, default/large text, narrow/wide, light/dark, TalkBack/VoiceOver, and iOS edge/peek. Existing Android evidence remains PARTIAL at its recorded original inputs. A separate HTML explainer is omitted for this short callback/layout change; the outline below is the complete review model.

Change outline

Chats row (no persistent overflow button or reserved column)
  swipe → Pin/Unpin · Add to section · Mute/Unmute
  Android long press → existing full native action menu
  iOS Link preview + context menu → same full menu, no extra long-press handler
  screen-reader custom actions → same callbacks, including Mark as read
                                  ↓
                         existing Host operations

chatList.gutter = 16
  header icon container / row avatar (slot inset compensated) / trailing swipe rail
  native glyph drawing bounds and actual hit/clip geometry still need measurement

The existing #2554 horizontal title/time and single-line preview stay intact. The menu includes Mark as read for eligible unread rows, while the rail stays at three actions. Cloud rows and Bots without a DM retain their existing availability. Source coverage drives the actual row and preview components through native boundary shims; it cannot prove native gestures or geometry.

Before reference only: the earlier approved Android capture shows the persistent overflow column and fully-open rail. This is not an after image or a validation of the current candidate; after screenshots will be added by the assigned native runner.

Earlier Android Chats row with persistent overflow and revealed actions

Native journey covers the new entry points and geometry distinctions. The Human's private photo is not published. The earlier fully-open rail bounds did not cross the screen edge; this change does not assert an overflow root cause.

Closes #2588. Refs #2519. Agent-Task: codex/local/01a16196-5d76-7442-8c66-95cdef39752c.

Remove the permanent overflow column. Preserve shared actions through Android long press, iOS Link preview context menus, swipe and screen-reader actions, including mark-read. Use shared Chats gutters with avatar slot compensation and retain #2554 text layout.

Source-only candidate: targeted existing formatter and git diff --check passed. Tests/typecheck and native geometry or interaction checks await CI/test-center allocation; no overflow root cause is claimed.

Issue: #2588

Agent-Task: codex/local/01a16196-5d76-7442-8c66-95cdef39752c
@coderabbitai

coderabbitai Bot commented Oct 22, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 27c3a310-085d-4b7a-b829-64fc54eb264f
📥 Commits

Reviewing files that changed from the base of the PR and between cd38a52 and 0ea9003.

📒 Files selected for processing: 9
  • .agents/skills/verify-deepseekbot/features/phone-chat-row-actions.md
  • apps/mobile/DESIGN.md
  • apps/mobile/src/ui/chat/conversation-row.tsx
  • apps/mobile/src/ui/chat/conversation-swipe-actions.tsx
  • apps/mobile/src/ui/design/tokens.ts
  • apps/mobile/src/ui/shell/conversation-peek.tsx
  • apps/mobile/src/ui/shell/home-header.tsx
  • apps/mobile/test/home-search.test.tsx
  • changes/2588-chat-row-context-actions.md
+----------------------------------------------+
| Cleaning up the mess Copilots left behind... |
+----------------------------------------------+
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@DoodleBears
DoodleBears merged commit 4db991b into main Oct 22, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Phone Chats: simplify row menus and align horizontal gutters

1 participant