Repository navigation
fix(mobile): make LAN network-security domains explicit (#2599) - #2605
Merged
Merged
Conversation
Issue: #2599 Agent-Task: codex/local/01a1639d-a211-7a30-a976-b6f6416ca9b1 Source-only QA follow-up; checks await the shared center allocation.
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 3
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
DoodleBears
marked this pull request as ready for review
October 22, 2026 19:18
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2599 · Parent #2598 · Claim
Task:
codex/local/01a1639d-a211-7a30-a976-b6f6416ca9b1Why the change
Fix the four missing-attribute errors that stopped the shared Android Release build at
:app:lintVitalReleaseby making each existing network-security domain explicitly exact-match.Special things to note
falsevalues; no wildcard or subdomain access is added.git diff --checkpassed; Exact-head CI 39838495115 passed all applicable jobs: static lint/format/typecheck/build, selected tests, mobile verification and isolated Host smoke. Native-module/full-shard/docs jobs were skipped by the plan; they are not native-build passes. Local source checks were not repeated; the center has now passed Release lint and both Android builds on the merged main recorded below. The previous LAN Kotlin compilation passed, but that does not qualify this fix. A new native build is required; no QA worktree or generated native file was modified.Change outline
The source config plugin generates the same four exceptions:
The existing native LAN socket test now asserts the complete four-domain declaration and
base-config cleartextTrafficPermitted="false"; a bilingual release fragment records the build fix.Proposed local source check (not yet allocated):
pnpm exec vitest run apps/mobile/test/native-lan-socket.test.ts --maxWorkers=1 --no-file-parallelism. After merge, the QA owner cuts a new recorded main revision and reruns prebuild/Release lint through the shared lane; the failed frozen build is preserved as evidence.Merged at 2026-10-22T19:22:49Z as
843d84b1c304a6dfac4c405c1da70ebfe2512ed1. The QA center rebuilt this exact main; the prior9cd926c0Release lint failure remains recorded. Binary qualification below does not claim phone acceptance.Android build qualification PASS — 2026-10-22: exact main
843d84b1c304a6dfac4c405c1da70ebfe2512ed1, including #2597/#2600/#2605. Fresh prebuild emits fourincludeSubdomains="false"attributes;:app:lintVitalReleasepasses. Release build succeeded in 17m41s and Debug in 4m47s, serial Gradle max-workers 2, actual Node 24.21.0 / pnpm 12.4.2.9018D62C4CD5B3EDC79C8BE9DF0EFB49BF873F9B0C5AE85B0D7FC628EC928E44EF7BE31A0E7E8DB05D72AB001491E83CDCF35EB40561EAFB418014E906336ED8Both use
ai.botharness.deepseekbot.devand the existing local debug signer; neither is a store distribution build. Actual APK package/ABI/signature, LAN DEX class and compiled network-policy binding passed inspection. Release class/resource renaming was resolved through R8 mapping and the APK resource table. Release contains the JS bundle and is non-debuggable.Final strict post-CNG Android fingerprint, including the generated native directory:
1da81501f7520b1b26002d234fae90eb3041b389(234 sources). This was recomputed serially after stable builds; an earlier computation overlapping prebuild was discarded. Do not equate this mode directly with a pre-CNG fingerprint.UNTESTED: installation/cold launch of these APKs, encrypted LAN pairing/offline Feed/DM/restart/revoke/disable, performance/FPS, screenshots and iOS. No app install, Host, Metro or phone UI/settings/pairing/reverse changes occurred. Only designated POCO Android 16/API36 identity/ABI/OS was read. Own processes/listeners were cleared and lease released at
20:04:15.7163242Z; global ADB was untouched.