Skip to content

fix: query diagnostics only for visible documents - #32

Merged
Adnan9-63 merged 1 commit into
Buildingcoolstuff:mainfrom
yuefdev:fix/visible-document-diagnostics-26
Oct 19, 2026
Merged

Adnan9-63 merged 1 commit into
Buildingcoolstuff:mainfrom
yuefdev:fix/visible-document-diagnostics-26

Conversation

@yuefdev

@yuefdev yuefdev commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

Description

Query diagnostics only for visible documents, once per URI even in split editors. Error counting, fixed-error credit and mood changes keep their existing behaviour.

Fixes #26.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • node --test: passed. The regression drives the extension's diagnostics callback and checks query scope, split-editor deduplication, error credit and an empty editor list.
  • node --check extension.js: passed.
  • Manual test in VS Code Extension Development Host
  • Verified SVG renders correctly (not applicable)

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation (CHANGELOG.md).
  • My changes generate no new warnings/errors in the console (not checked in a live host).

No test or lint scripts are defined in package.json; the regression uses Node's built-in test runner.

@Adnan9-63 Adnan9-63 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Fantastic work @yuefdev 🚀

Everything looks super clean. Thanks for fixing this performance bottleneck and updating the CHANGELOG! Merging now.

@Adnan9-63
Adnan9-63 merged commit 72ac99e into Buildingcoolstuff:main Oct 19, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scope diagnostics check to visible text editors to prevent workspace scan lag

2 participants