Add backward scrolling support to disassembly view - #564
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds the ability to scroll backward in the disassembly view, using heuristics based on scanning the 64 prior bytes to determine the most likely preceding instruction. If a preceding instruction is matched, it is disassembled and prepended directly to the view, providing efficient scrolling behavior. If no preceding instruction is matched, it falls back to stepping back by one byte and fully repopulating the view from this new starting point.
This also includes a fix for a bug which would allow instructions beyond the end of the address space to be disassembled when scrolling forward.