Repository navigation
fix(scout): restore discrepancy detection and confirmed repairs - #197
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
datatrail scoutcould crash when no scopes were given, miss Minoc discrepancies, and send site checksums to a misspelled endpoint. Site checksum responses also use absolute filenames, but the repair endpoint expects names relative to the dataset. Passing them straight through could report a successful repair without creating any replicas.Scout now works from the returned scopes and each scope's own site set, adds the Minoc count from its own query when it picks discrepancies, and shows every storage site that's reported. Checksums come from the correct endpoint, and remote filenames are normalized to the names the backend expects, with strict checks on the root and dataset boundaries.
Each repair still needs its own confirmation. An invalid report, a failed query, or a malformed checksum payload blocks the affected repair and gives a nonzero exit status. Independent confirmed repairs can still go ahead after a failure.
I added 45 regression cases. They cover Minoc recovery, omitted scopes, different site sets, CHIME/baseband-buffer comparisons, realistic absolute checksum paths, cancellation, and HTTP/transport/payload failures. The whole non-CADC suite passes on Python 3.10 and 3.14 (343 tests on each), and all pre-commit hooks pass. The nine tests that need CADC credentials weren't run, and no live archive repairs were done.
Fixes #85.
Fixes #86.
Fixes #104.