Repository navigation
refactor: 승인·반영·거절의 트랜잭션 블록이 값을 반환하게 하고 트랜잭션 선언을 클래스에 한 번만 둠 - #710
Merged
Merged
Conversation
- 블록 밖으로 값을 꺼내던 배열 참조 9개를 블록이 돌려주는 레코드 3개로 교체 - 공개 메서드마다 붙어 있던 NOT_SUPPORTED를 클래스 선언으로 모음(동작 변화 없음) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경 (
AdminRequestCommandService, 동작 변화 없음)X[] ref = {null}9개를, 블록이 돌려주는 레코드 3개(ApprovalPreparation,ApprovalOutcome,Rejection)로 교체NOT_SUPPORTED를 클래스 선언 하나로 모음. 기존 클래스 선언(일반 트랜잭션)은 적용되는 메서드가 없었다.범위 밖
RequestExpiryService,PodMigrationService,PortOperationService에 같은 배열 참조 5개가 남아 있다.확인
./gradlew cleanTest build --rerun-tasks통과, 테스트 1327건 실패 0건확인하지 못한 것
🤖 Generated with Claude Code