Repository navigation
refactor: 알림 서비스에서 전송 큐·메일 발송·신청서 채널 알림·안내 메일을 떼어 냄 - #711
Merged
Merged
Conversation
- AlarmService는 성격별 창구(조치 필요·처리 기록·사용자 안내·메일 안내)만 남김 - SlackNotificationQueue(큐 적재와 장애 시 직접 전송), NotificationMailer(메일 발송), NotificationChannels(채널 주소) - RequestChannelNotifier(신청서 채널 알림 7종), UserGuideMailer(안내 메일 9종) - 보내는 내용·채널·시점은 그대로, 문구 키 31개 동일 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경
737줄이던
AlarmService가 큐 전송, 메일 발송, 채널 선택, 문구 작성을 모두 맡고 있어, "어떻게 보내는가"와 "무엇을 쓰는가"를 나눴다. 보내는 내용·채널·시점은 바꾸지 않았다.AlarmServicealertNeedsAction,recordLog,notifyUser,mailUserSlackNotificationQueueNotificationMailerNotificationChannelsRequestChannelNotifierUserGuideMailerAlarmService.mailUser에 둠 — 메일러로 옮기면 서로 참조하게 된다.테스트
AlarmServiceTest는 실제 객체를 이어 붙여 호출부터 큐에 실리는 글·보내는 메일까지 그대로 검증(파일 분리는 하지 않음)확인
./gradlew cleanTest build --rerun-tasks통과, 테스트 1329건 실패 0건(건수 변화 없음)확인하지 못한 것
🤖 Generated with Claude Code