Repository navigation
refactor: 호출처 없는 메서드·저장소 조회·클래스와 초기 생성 안내문을 지움 - #714
Merged
Merged
Conversation
- 운영 코드에서 부르지 않는 서비스·엔티티·DTO 메서드 8개와 저장소 조회 5개를 지움 - 참조 없는 클래스 4개(UserGroupUpdateRequestDTO, ForbiddenException, InternalServerException, UserAuthentication)를 지움 - gitignore 대상인데 추적되던 HELP.md와 쓰이지 않는 import를 지움 - 지운 메서드만 부르던 테스트를 정리하고 JwtProviderTest는 parseAccessToken으로 검증함 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
무엇을
운영 코드 어디에서도 부르지 않는 코드를 지웠습니다. 동작 변화는 없습니다.
PortRequestService.getPortRequestsByResourceGroupId,SaveRequestResponseDTO.fromEntityWithPortMappings,Request.updateResourceGroup·updateContainerImage,RequestQueryService.getActiveContainers,User.getUbuntuGidsOfGroups,JwtProvider.validateAccessToken,BaseTimeEntity.setUpdatedAtPortRequestRepository.findByResourceGroupRsgroupId,ContainerImageRepository.findByImageNameAndImageVersion,ChangeRequestRepository.findAllByRequestedBy_UserIdAndStatus,RequestRepository.existsByUser_UbuntuUsernameAndUser_UserId,UserRepository.findByUbuntuUsernameUserGroupUpdateRequestDTO,ForbiddenException,InternalServerException,UserAuthenticationHELP.md,SlackApiService의 군더더기 주석, 쓰이지 않는 import테스트
getActiveContainers테스트 1건을 메서드와 함께 지웠습니다.JwtProviderTest는 같은 검증을parseAccessToken으로 부릅니다(validateAccessToken은 이 메서드를 그대로 부르는 껍데기였습니다).AdminModificationCommandServiceTest에서 지운 메서드를 가리키던 확인 두 줄과 원래부터 안 쓰이던 import를 지웠습니다.확인
./gradlew build통과, 테스트 1332건 실패 0.🤖 Generated with Claude Code