Fix fatal PRIMARY KEY (Array) on fresh install from array primary key

[TheWitness]

Problem

On a fresh install (and whenever the upgrade path creates a missing table), gexport hands api_plugin_db_table_create() a table definition whose primary is declared in the array form:

$data['primary'] = ['id'];

Down to this plugin''s compat = 1.2.29 floor, api_plugin_db_table_create() (lib/plugins.php) interpolates the primary key straight into the DDL string:

$sql .= ",\n PRIMARY KEY (`" . $data['primary'] . '`)';

With an array, PHP renders it as PRIMARY KEY (`Array`), so the CREATE TABLE fails and the table is never created on Cacti 1.2.29-1.2.31.

This is the fresh-install mirror of the upgrade-path fatal fixed in plugin_routerconfigs #191: api_plugin_db_table_create() requires the scalar primary form, while db_update_table() requires the array form.

Fix

Add a gexport_create_definition() helper that flattens an array primary to the backtick-joined scalar form, and wrap every api_plugin_db_table_create() call with it. The canonical *_table_data() definitions keep the array form that db_update_table() still requires on the upgrade path, so both paths get the form they need. This mirrors the helpers already present in plugin_maint, plugin_apcupsd, plugin_exlist, plugin_lsflog and plugin_stream.

Validation

• php -l includes/database.php - no syntax errors.
• Added regression coverage asserting the create API receives a scalar primary while the shared definitions keep the array form.

[Copilot]

🟢 Approval recommended

The focused fix covers all creation paths, preserves existing-table updates, and has no unresolved findings.

0 open findings

What changed in this PR

Fixes table creation failures by adapting primary-key definitions to Cacti’s create API while preserving the array format required for schema updates.

Changes:

• Converts array primary keys to scalar strings on all table-creation paths.
• Adds regression coverage for scalar creation keys and unchanged canonical definitions.

File	Description
tests/​Unit/​GexportSetupTableTest.php	Tests primary-key formats for creation and canonical definitions.
includes/​database.php	Adds the conversion helper and applies it to install and upgrade creation paths.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.