Repository navigation
build: track work as labelled issues, and check each PR's labels, milestone, branch and issue link - #69
Open
CaffeinatedCoder wants to merge 2 commits into
Open
build: track work as labelled issues, and check each PR's labels, milestone, branch and issue link#69CaffeinatedCoder wants to merge 2 commits into
CaffeinatedCoder wants to merge 2 commits into
Conversation
…abels, milestone, branch and issue link The repository had 66 pull requests and no issue, milestone or label of its own. It adopts CodoMetis.ValueRanges' scheme (decision 109): - issue forms for a bug, an enhancement and an epic, with blank issues off and security reports sent to the private advisory form; a pull request template (Closes #n, Problem, Change, Tests); - labels: one type, a severity on a bug, package/* and area/*, silent, breaking, found-by/prober, stacked, epic. The legend is in CONTRIBUTING's "Issues and labels", and AGENTS.md has an Issues section; - a release is an epic with a milestone of its version; the roadmap stays in design/roadmap.md. pr-hygiene.yml runs tools/PrHygiene on the event payload of every pull request into main or a release branch. ValueRanges' check is a bash script; under decision 92 this one is a tool project, BCL only, with its tests. Besides ValueRanges' rules (one type label, a severity on a bug, a closing reference), it holds decision 94's branch naming against the type label, the release's milestone, silent only on a bug, and breaking only into a major. Each rule was proved by deleting it from the tool: 12 seeds, each caught by the 41 tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CaffeinatedCoder
added
chore
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #68
Problem
The repository tracked no work as issues: 66 pull requests, no issue, no milestone, and no labels of its own. What was open, what a pull request was for and which release it belonged to could only be read from files and branch names.
Change
CodoMetis.ValueRanges' scheme, fitted to decisions 92 and 94 (decision 109):
.github/ISSUE_TEMPLATE/: Bug (silent or loud, package, version), Enhancement (does it break anything?), Epic, andconfig.yml(blank issues off, security reports go to the advisory form)..github/pull_request_template.md:Closes #, Problem, Change, Tests.tests,chore,epic,breaking,silent,found-by/prober,stacked,severity/*×4,package/*×7,area/*×7..github/workflows/pr-hygiene.ymlrunstools/PrHygiene(new tool project, BCL only, in the solution andAgentTools.slnf) on the event payload. Like ValueRanges' check it fails a missing type label, a bug without exactly one severity, or no closing reference. It also fails a branch whose<type>/disagrees with its type label, a PR intorelease/<v>(orrelease/<v>intomain) without the milestone<v>,silenton anything but a bug, andbreakinginto anything but a major. Dependabot is skipped. No token, nothing of the PR's code run.design/roadmap.md, so there is no roadmap issue or label. A release epic links its section instead, as Epic: 2.3.0 #67 does.Tests
test/CodoMetis.TypeKit.PrHygiene.Tests: 41 cases run the built tool on payloads, covering a pass and a fail for every rule, each closing keyword, Dependabot, usage errors, and a stale build (exit 3).problems.Add, the\bbefore the keywords, the release-head fallback, the Dependabot skip, a branch-to-label mapping), and the tests caught every one.🤖 Generated with Claude Code