Repository navigation
test: read the pull_request trigger's settings whatever their YAML spelling - #239
Merged
Merged
Conversation
…elling The convention test from #203 matched lines indented by four spaces right after `pull_request:`, so a flow mapping (`pull_request: { branches: [...] }`) and a block after a blank line both passed with a branch filter present. It now takes the text after the key's colon plus every deeper-indented line up to the next key, comments removed. Found-By: pre-tag analysis (#179) Defect-Class: weak-guard Closes #237 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CaffeinatedCoder
added
tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #237
Problem
ReleaseWiringConventionTests.PullRequests_AreBuiltWhateverTheirBase(#203) read thepull_requestblock with a regex over lines indented by four spaces. The pre-tag analysis (#179) found two valid spellings that pass with a branch filter present: a flow mapping (pull_request: { branches: [ "main" ] }), and a block after a blank line.Change
A
TriggerSettingshelper takes the text after the trigger's colon plus every following line indented deeper than the key, up to the next key at the same or shallower indentation, with comments removed. The two assertions (nobranches, noedited) read that.Tests
Seeded into
.github/workflows/dotnet.yml, one at a time, restored after each:branchesbranchesbranchesbranchestypes: [ …, edited ]branchesConventions suite: 395 passed.
🤖 Generated with Claude Code