Repository navigation
fix: align WASM size budget with Callora contract limit - #1369
Closed
rikkhope-cyber wants to merge 8 commits into
Closed
rikkhope-cyber wants to merge 8 commits into
rikkhope-cyber wants to merge 8 commits into
Conversation
Clarified the Callora contract WASM size budget and corrected the previous claim of 64 KB. Removed outdated configuration details and emphasized the importance of the 100 KiB limit.
Removed 'continue-on-error' from several steps to ensure failures are reported.
Removed unnecessary header and outdated sections from README.
Align the Callora contract WASM size documentation and checks around a single 100 KiB (102400-byte) project budget. This change: - Corrects the outdated Soroban 64 KB claim in Cargo.toml. - Documents the 100 KiB Callora contract WASM budget. - Keeps the size-check script and CI aligned at 102400 bytes. - Ensures the WASM size check reports per-contract headroom. - Updates the README to refer to the Callora contract WASM budget instead of calling it Soroban's network-wide limit. - Removes continue-on-error from the WASM size CI workflow so size-check failures can properly fail the job. No contract logic or dependency changes are included.
Removed the SettlementError enum definition from batch.rs.
Refactor batch settlement error handling to use the shared SettlementError type and improve batch validation. This change removes the duplicate SettlementError definition from batch.rs and reuses the contract-wide error type from errors.rs. It also adds clear handling for empty batches, oversized batches, and cross-tenant batches while preserving per-item settlement outcomes. Individual settlement errors are converted into SettleOutcome values so each input receives a corresponding result, while batch-level validation errors are returned before processing begins. No changes are made to the settlement error codes or contract business logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1234.
This PR aligns the Callora contract WASM size checks and documentation around the project's 100 KiB (102400-byte) budget.
Changes
Cargo.toml.continue-on-errorfrom the WASM size workflow so size failures can fail CI.No contract logic or dependency changes are included.