Repository navigation
Firefly-2032: Add Direct Download of Files - #2048
Merged
Merged
Conversation
loitly
approved these changes
Oct 26, 2026
aventura121
force-pushed
the
FIREFLY-2032-direct-download
branch
from
October 26, 2026 19:18
7f54633 to
00e2f38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Firefly-2032: Add direct-download capability to Job Monitor
Description
We add download buttons/functionality to the Job Monitor and the Info icon's Results tabs, including for multiple results (e.g. SPHEREx).
Builds
Firefly: https://firefly-2032-direct-download.irsakubedev.ipac.caltech.edu/firefly
SPHEREx: https://firefly-2032-direct-download.irsakubedev.ipac.caltech.edu/applications/spherex
Approach
Essentially, we add a new streaming API to Firefly, passing the data along to the browser. (For due diligence, I had Claude double check if any third party / standard Java libraries offered what we wanted out of the box or with less complication. Where we landed in this pull request is the most straightforward and suitable). We also add a read timeout to the remote request. If we leave it to 0, a remote that stops sending data without closing the connection would hang the download indefinitely.
Testing/Validation
Unit/integration tests added (integration tests using a simple http server and fakes).
To manually spot check in Firefly, we can create a job and download a file. For example:
New Download Button in Job Monitor
New Download Button in Info -> Results Panel
To see the download buttons added to the Info icon's Results tab for multiple results, in SphereX:
New Multiple Results Buttons in Info -> Results Panel
Remote server error (404) handled gracefully