Skip to content

Run PR checks on GitHub-hosted runners - #6

Merged
maestro957 merged 2 commits into
masterfrom
ci/github-hosted-pr-checks
Nov 16, 2026
Merged

maestro957 merged 2 commits into
masterfrom
ci/github-hosted-pr-checks

Conversation

@maestro957

@maestro957 maestro957 commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Description

This PR moves the pull-request checks in this public repo off our self-hosted centeva-strix runners and back onto GitHub-hosted ubuntu-latest.

On a public repo, anyone can open a pull request from a fork, and the Checks workflow runs that pull request's code: npm ci, lint, build and tests. On centeva-strix, that code runs inside our cluster. GitHub-hosted minutes are free for public repos, so moving back costs nothing.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Tests
  • 🤖 Build/CI
  • 📦 Chore (Version bump, release, etc.)
  • ⏩ Revert

Related Tickets & Documents

Reverses the runner change from #4 and #5 for the PR checks only.

Changes Made

  • .github/workflows/pr-tasks.yml: the Test Angular workspace job now runs on ubuntu-latest instead of centeva-strix. I removed the actions-runner container, which was only needed on strix.
  • .github/workflows/pr-tasks.yml: removed the Lint step. The workspace has had no lint target since the Angular 13.3.11 update, so ng lint failed before the build and tests could run. Add angular-eslint and restore the Lint step in PR checks #7 tracks bringing linting back with angular-eslint.
  • build-publish-npm.yml already runs on ubuntu-latest and is unchanged.

Screenshots (if applicable)

N/A

Quality Checklist

  • I have added or updated automated tests as needed.
  • I have reviewed the code changes myself.
  • I have used commit messages that adequately explain my changes.
  • I have removed any extra logging, debugging code, and commented out code.
  • I have updated any related documentation (if necessary).

Additional Notes

  • Settings protect the repo partly today: a first-time contributor's workflow runs need approval before they start. Approving one would still run that code on our cluster. After this change it would run on GitHub's runners.
  • This PR's own Checks run is on ubuntu-latest, so the workflow change is tested by the PR itself.
  • This is the first time Checks has completed successfully. Every earlier run was canceled while waiting for a strix runner. With the Lint step removed, the library build, the demo app build and both test suites pass on ubuntu-latest.
  • Not changed here: the job asks for packages: write, but none of its steps publish anything. It could be reduced to contents: read in a follow-up.

This repo is public, so pull requests from forks would run on our self-hosted
centeva-strix runners. GitHub-hosted minutes are free for public repos.
The workspace has had no lint target since the Angular 13.3.11 update, so
ng lint fails before the build and tests can run. Restoring linting with
angular-eslint is tracked in #7.
@maestro957 maestro957 self-assigned this Nov 16, 2026
@maestro957
maestro957 merged commit efe863b into master Nov 16, 2026
3 checks passed
@maestro957
maestro957 deleted the ci/github-hosted-pr-checks branch November 16, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants