Repository navigation
Claude/sleepy johnson al1ndh - #6
Merged
Merged
Conversation
- Give in-load cache read/write their own 1s timeout so a slow cache cannot consume LoadTimeout. - Scope singleflight key by Cache instance so identical keys on different caches load separately. - Treat negative TTL as no expiry; reject SetNX ttl <= 0 with ErrInvalidTTL. - Document Load must not panic, nil-sentinel collision, stale-write race. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PPH4seaqkaPedocjzkHZ4L
- Diagram: per-cache flight key, separate 1s cache timeouts, panic row, drop blog front matter and stale 'was removed' wording. - README: drop the copied interface block and layout table, link to the diagram doc instead of repeating it, use log.Fatal in the example. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PPH4seaqkaPedocjzkHZ4L
The previous commit removed it on the assumption nothing used it. Restore it, including links.github, and bump updated. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PPH4seaqkaPedocjzkHZ4L
…ght key - Apply cacheOpTimeout to the first lookup too. - Set ContextTimeoutEnabled so go-redis honours ctx deadlines; without it the 1s cache limits did nothing against a hung Redis (9s measured, 3s now). - flightKey: only scope by pointer Caches; fall back to the key otherwise. - jitter returns 0 for non-positive ttl instead of the caller clamping. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PPH4seaqkaPedocjzkHZ4L
The unit tests (miniredis) cover the same behaviour without Docker. Drop cache/example, the testcontainers dependency, the cache entry in the CI integration matrix and the Docker wording in the Makefile and docs. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PPH4seaqkaPedocjzkHZ4L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.