fix(admin): drop the duplicate restart banner from the Peers tab (CLEAN-98) - #97
Merged
Merged
Conversation
…AN-98) The agent page already raises a restart banner above every tab, and the peer store is what raises it — connect, import, refresh and remove all call markPendingRestart. The copy inside the Peers tab added a second button for the same job, wired to a different code path, and it did not clear the page banner when pressed, so the tab kept telling the operator to restart an agent that had just restarted. What the page banner cannot know stays where it was: the armed badge next to "Peer network" still reports whether the RUNNING pod holds this peer set. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SZ9dCrzZqd5SwR4erLYe12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last commit of #91 never made it into the squash —
mainstill carries the restart banner inside the Peers tab. This is that commit, cherry-picked onto currentmain.The agent page already raises a restart banner above every tab, and the peer store is what raises it: connect, import, refresh and remove all call
markPendingRestart. The copy inside the tab was a second button for the same job on a different code path — it calledagentStore.restartdirectly, so unlike the page banner's button (useAgentLifecycle.restart→clearPendingRestart+ in-flight overlay +refresh) it left the banner standing and the page unrefreshed. Pressing it looked like nothing happened.The armed badge next to Peer network stays: it reports what the running pod actually holds, which the page banner cannot know.
No version bump here — it would collide with #96 for no reason.
Verification:
npx nuxt typecheckinadminreports nothing from this change (the one error it does report,reins/data/knowledge.gateway.tsretrying, is pre-existing onmain— the committed SDK has been stale since CLEAN-96). The SFC compiles.Jira: CLEAN-98
🤖 Generated with Claude Code
https://claude.ai/code/session_01SZ9dCrzZqd5SwR4erLYe12