Skip to content

chore(playwright): restore corepack in the Docker image - #1287

Merged
XOP merged 2 commits into
mainfrom
claude/loving-nightingale-4811eb
Nov 10, 2026
Merged

XOP merged 2 commits into
mainfrom
claude/loving-nightingale-4811eb

Conversation

@XOP

@XOP XOP commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Description

  • Dockerfile.playwright deletes /usr/bin/yarn and /usr/bin/yarnpkg, runs npm install -g corepack, then activates yarn@4.5.3 from packageManager.

Links and tickets

Good to know

  • Node 26 has no corepack. npm install -g corepack hits EEXIST on yarn 1, so the Dockerfile deletes yarn 1 first.
  • CI is unaffected: visual-regression-tests.yml uses actions/setup-node 24.x.
  • build --no-cache and yarn test:visual Alert (42/42) pass. No changeset, tooling only.

Checklist

  • Breaking changes? (add migration notes in changesets) — no
  • Visual changes? (specify in changesets) — no
  • Design review needed? — no

Contribution

  • Sufficient research before PR
  • Self-reviewed the PR
  • Manually tested the changes (when applies - visual confirmation in Storybook) — docker compose build --no-cache and yarn test:visual Alert (42 passed)
  • build and build-storybook work locally — not run; only Dockerfile.playwright changed, which neither command reads
  • Tests and Stories are aligned with the changes — not applicable, no component changed

Accessibility

Skipped: no component markup, behavior or styles changed.

Screenshots

None.

🤖 Generated with Claude Code


Note

Low Risk
Tooling-only Docker change with no runtime or component impact; CI visual tests use a separate Node setup path.

Overview
Updates Dockerfile.playwright so visual-regression Docker builds work on the current Playwright base image (Node without bundled Corepack).

The install step now removes legacy Yarn 1 binaries (/usr/bin/yarn, /usr/bin/yarnpkg) before npm install -g corepack, then enables Corepack and pins Yarn 4.5.3 as before. This avoids conflicts when installing Corepack globally and restores the project’s Yarn 4 workflow inside the container used by docker-compose.playwright.yml.

Reviewed by Cursor Bugbot for commit 8b4ec1e. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8b4ec1e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@XOP XOP added the infra CI, workflows, scripts label Nov 3, 2026
@workflow-authentication-public

Copy link
Copy Markdown
Contributor

Storybook Preview Deployed

✅ Preview URL: https://click-9luo8mif6-clickhouse.vercel.app

Built from commit: b0070c23e6a7b62772caf04c6b18ddbe90b3365e

@workflow-authentication-public

Copy link
Copy Markdown
Contributor

Chromatic Storybook

Check Status Link
Storybook ✅ 670 stories published Open Storybook
UI Tests ✅ 670 tests unchanged Open build

Built from commit: 8b4ec1eda43bac4525d4b249e0cc7b345489c074 · Chromatic run

Statuses as of the end of the run. The build link shows the live review state.

@XOP
XOP merged commit 8c156b1 into main Nov 10, 2026
11 checks passed
@XOP
XOP deleted the claude/loving-nightingale-4811eb branch November 10, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infra CI, workflows, scripts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants