Repository navigation
chore(playwright): restore corepack in the Docker image - #1287
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Storybook Preview Deployed✅ Preview URL: https://click-9luo8mif6-clickhouse.vercel.app Built from commit: |
Chromatic Storybook
Built from commit: Statuses as of the end of the run. The build link shows the live review state. |
Description
Dockerfile.playwrightdeletes/usr/bin/yarnand/usr/bin/yarnpkg, runsnpm install -g corepack, then activatesyarn@4.5.3frompackageManager.Links and tickets
playwright:v1.64.1-noble. I found it while reviewing fix(Icon): match information icon stroke to the icon set #1283.Good to know
corepack.npm install -g corepackhitsEEXISTon yarn 1, so the Dockerfile deletes yarn 1 first.visual-regression-tests.ymlusesactions/setup-node24.x.build --no-cacheandyarn test:visual Alert(42/42) pass. No changeset, tooling only.Checklist
Contribution
docker compose build --no-cacheandyarn test:visual Alert(42 passed)buildandbuild-storybookwork locally — not run; onlyDockerfile.playwrightchanged, which neither command readsAccessibility
Skipped: no component markup, behavior or styles changed.
Screenshots
None.
🤖 Generated with Claude Code
Note
Low Risk
Tooling-only Docker change with no runtime or component impact; CI visual tests use a separate Node setup path.
Overview
Updates
Dockerfile.playwrightso visual-regression Docker builds work on the current Playwright base image (Node without bundled Corepack).The install step now removes legacy Yarn 1 binaries (
/usr/bin/yarn,/usr/bin/yarnpkg) beforenpm install -g corepack, then enables Corepack and pins Yarn 4.5.3 as before. This avoids conflicts when installing Corepack globally and restores the project’s Yarn 4 workflow inside the container used bydocker-compose.playwright.yml.Reviewed by Cursor Bugbot for commit 8b4ec1e. Bugbot is set up for automated code reviews on this repo. Configure here.